Add in and out edge indices functions #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
Pull Request Test Coverage Report for Build 12926634311Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
The current implementation looks good to me. I left some minor nitpick comments but they are not blocking.
What is going to be more work is adding even more methods...
PyGraphshould have the same methods even if the implementation is just callingincident_edgesfor consistencyPyDiGraphandPyGraphcould use aout_edge_indices
So that is 3 more methods which were in the original request but are useful to maintain some coherence accross the API
IvanIsCoding
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
LGTM but I will run this through @mtreinish before adding four similar methods for a second opinion
|
Also, Matthew kindly reminded me: Congratulations on snatching commit 1000 🥳 🥳 |
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
* Add method to retrieve incoming edge indices for a node * Add type annotations in stub file * Add tests for in_edge_indices * Add method to get outgoing edge indices for a node * Add in_edge_indices and out_edge_indices methods in PyGraph * update stub file * Add tests for out_edge_indices and in_edge_indices * Add release notes for in_edge_indices and out_edge_indices functions * Change releasenote name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method, in_edge_indices, to the rustworkx.PyDiGraph class. The method returns the indices of incoming edges for a specified node.
#1360
I'll add the documentation once the function signature is finalized.