Add Local Complementation #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assure multigraphs are not allowed and local complementation is not defined for digraphs. Self loops are assumed to not exist in the provided grahps. Added test
|
|
|
|
Pull Request Test Coverage Report for Build 12998721628Details
💛 - Coveralls |
There was a problem hiding this comment.
Thanks for making your first contribution! It is very welcome, this seems to be a more niche function and that is fine. rustworkx has plenty of methods that are more Quantum Computing centric let's say.
I did leave comments and there are still some TODOs:
- Adding type annotations, the CI is failing because they are missing https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#type-annotations
- Sign the CLA
Lastly, I can do this for you when I merge the code but feel free to do it yourself if you want:
- Adding release notes https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#release-notes
- Add your method to the documentation somewhere in https://github.com/Qiskit/rustworkx/tree/main/docs/source/api
…igraph_local_complement, add&improve tests
IvanIsCoding
approved these changes
Jan 28, 2025
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
* First implementation and possible impl. ideas as comments * Enable python interface to local_complement. First tests. * Only multigraphs and no digraphs Assure multigraphs are not allowed and local complementation is not defined for digraphs. Self loops are assumed to not exist in the provided grahps. Added test * redundant docstring sentence removed * Add method to docs, add release notes, add type annotations, remove digraph_local_complement, add&improve tests * update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1365.
Any comments on the tests, documentation and the error handling are welcome.