Skip to content

Conversation

IvanIsCoding
Copy link
Collaborator

This adds Python 3.13 to CI and bumps cibuildwheel to the latest version.

I will test the wheel build on my personal repository before merging.

@IvanIsCoding IvanIsCoding requested a review from mtreinish October 4, 2024 22:27
@@ -24,7 +24,7 @@

def install_rustworkx(session):
session.install(*deps)
session.install(".", "-c", "constraints.txt")
session.install(".[all]", "-c", "constraints.txt")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this by accident in #1290

@IvanIsCoding
Copy link
Collaborator Author

Putting this on hold until October 7

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11769405948

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.825%

Totals Coverage Status
Change from base Build 11709175986: 0.0%
Covered Lines: 18016
Relevant Lines: 18801

💛 - Coveralls

@IvanIsCoding
Copy link
Collaborator Author

And we are affected by python-pillow/Pillow#6676, MyPy is getting smarter although not when I wanted

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but before merging we probably should update the trove classifiers in the setup.py: https://github.com/Qiskit/rustworkx/blob/main/setup.py#L72

@IvanIsCoding
Copy link
Collaborator Author

This LGTM, but before merging we probably should update the trove classifiers in the setup.py: https://github.com/Qiskit/rustworkx/blob/main/setup.py#L72

I added 3.13 to that list. I also just removed win32 from the wheels being built because of #1293. I will test the wheels build in my repository before merging.

@IvanIsCoding
Copy link
Collaborator Author

The test build is running at https://github.com/IvanIsCoding/rustworkx/actions/runs/11332447391.

@IvanIsCoding
Copy link
Collaborator Author

The test build passed, all the failures are permission issues because we omitted the PyPI tokens. This is good to go

@IvanIsCoding
Copy link
Collaborator Author

After the NumPy bump in #1305 we no longer need to drop the Windows 32-bit build. All builds are working now

@mtreinish mtreinish added this pull request to the merge queue Nov 15, 2024
Merged via the queue into Qiskit:main with commit cb897b9 Nov 15, 2024
31 checks passed
Gohlub pushed a commit to Gohlub/rustworkx that referenced this pull request Nov 17, 2024
* Add 3.13 support

* Enable pillow for 3.13 tests

* Fix stub tests

* Bump cibuildwheel to build with candidate and not rc

* Remove win32 builds

* Add 3.13 to supported list

* Re-introduce win32
@IvanIsCoding IvanIsCoding deleted the py313 branch May 17, 2025 17:57
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
* Add 3.13 support

* Enable pillow for 3.13 tests

* Fix stub tests

* Bump cibuildwheel to build with candidate and not rc

* Remove win32 builds

* Add 3.13 to supported list

* Re-introduce win32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants