Skip to content

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #1243

We let this one slip through by accident.

@IvanIsCoding IvanIsCoding added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Jul 11, 2024
@IvanIsCoding IvanIsCoding requested a review from mtreinish July 11, 2024 03:40
@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 11114945229

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.816%

Totals Coverage Status
Change from base Build 10998985570: 0.0%
Covered Lines: 17999
Relevant Lines: 18785

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm a bit surprised this got through the tests but this is clearly correct.

@mtreinish mtreinish added this pull request to the merge queue Sep 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 29, 2024
@IvanIsCoding IvanIsCoding added this pull request to the merge queue Sep 29, 2024
@IvanIsCoding
Copy link
Collaborator Author

I think our merge queue is stuck, do we need to tweak the CI configs? https://github.com/Qiskit/rustworkx/queue/main

@IvanIsCoding IvanIsCoding removed this pull request from the merge queue due to a manual request Sep 29, 2024
@IvanIsCoding IvanIsCoding added this pull request to the merge queue Sep 30, 2024
Merged via the queue into Qiskit:main with commit 6096c8f Sep 30, 2024
29 checks passed
@IvanIsCoding IvanIsCoding deleted the fix-json-type-annotation branch September 30, 2024 22:47
mergify bot pushed a commit that referenced this pull request Sep 30, 2024
* Fix node_link_json type annotations

* Add release notes

* Try to fix link

* Try to fix merge queue hanging

(cherry picked from commit 6096c8f)
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
* Fix node_link_json type annotations

* Add release notes

* Try to fix link

* Try to fix merge queue hanging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Python stubs typing for node/edge attrs parameters in json serializers
3 participants