Change warning class for Aer and IBMQ warning #2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we started emitting on failed imports for IBMQ and Aer in Qiskit#2842 to tell users if they have a misconfigured or missing qiskit-aer or qiskit-ibmq-provider package. However, in that PR we set the warning class to ImportWarning which is ignored by default in python. This defeats the whole purpose of emitting the warning because no one will see it unless they explicit enable printing ImportWarnings to stderr. ImportWarning was chosen because it seems to map the best to what we're warning about and provides a unique enough class that is easy to filter for those users who do not wish to install either Aer or IBMQ. This commit changes the warning class to RuntimeWarning so that it will show by default but still meet the criteria that we original chose ImportWarning based on.
ajavadia
approved these changes
Aug 14, 2019
|
It looks like the azure<->github communication got yet stuck again (definitely reinforces merging #2979 as fallback before release). The jobs have all successfully completed running here: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=1818 but the checks list on github hasn't been updated for the second stage yet. I'm going to go ahead and merge this since all the checks came back as passing even though azure is still misbehaving on reporting that back to github. |
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
Recently we started emitting on failed imports for IBMQ and Aer in Qiskit#2842 to tell users if they have a misconfigured or missing qiskit-aer or qiskit-ibmq-provider package. However, in that PR we set the warning class to ImportWarning which is ignored by default in python. This defeats the whole purpose of emitting the warning because no one will see it unless they explicit enable printing ImportWarnings to stderr. ImportWarning was chosen because it seems to map the best to what we're warning about and provides a unique enough class that is easy to filter for those users who do not wish to install either Aer or IBMQ. This commit changes the warning class to RuntimeWarning so that it will show by default but still meet the criteria that we original chose ImportWarning based on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently we started emitting on failed imports for IBMQ and Aer in #2842
to tell users if they have a misconfigured or missing qiskit-aer or
qiskit-ibmq-provider package. However, in that PR we set the warning
class to ImportWarning which is ignored by default in python. This
defeats the whole purpose of emitting the warning because no one will
see it unless they explicit enable printing ImportWarnings to stderr.
ImportWarning was chosen because it seems to map the best to what we're
warning about and provides a unique enough class that is easy to filter
for those users who do not wish to install either Aer or IBMQ. This
commit changes the warning class to RuntimeWarning so that it will show
by default but still meet the criteria that we original chose
ImportWarning based on.
Details and comments