Ensure collect runs doesn't return an op with a condition #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an additional check that none of the ops output from the dagcircuit's collect_runs() function do not have a condition. There is a check on the first op in the run, but we never check if any other nodes in the run have a condition. A condition on any node in the run would end the run. This commit fixes the behavior to match this so we never return a node with a condition on it. Fixes Qiskit#2571
Added in: dbe1f07 |
ajavadia
approved these changes
Jun 6, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Ensure collect runs doesn't return an op with a condition This commit adds an additional check that none of the ops output from the dagcircuit's collect_runs() function do not have a condition. There is a check on the first op in the run, but we never check if any other nodes in the run have a condition. A condition on any node in the run would end the run. This commit fixes the behavior to match this so we never return a node with a condition on it. Fixes Qiskit#2571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds an additional check that none of the ops output from
the dagcircuit's collect_runs() function have a condition. There
is a check on the first op in the run, but we never check if any other
nodes in the run have a condition. A condition on any node in the run
would end the run. This commit fixes the behavior to match this so we
never return a node with a condition on it.
Details and comments
Fixes #2571