-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Added VF2PostLayout at the end of optimization stage for level 3 #14120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15110047730Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this mostly looks good to me, thanks for doing this. I left one minor suggestion inline. I'm almost disappointed that no tests broke from doing this, I was kind of hoping that this would find a place where the layout could be improved.
added suggestion for the seed Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Thanks for the feedback and the suggestion! Is there anything more I need to do on my end ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good @LenaPer! You could add a release note documenting the update to optimization level 3, I'd say it's a transpiler feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for doing this.
…kit#14120) * added VF2PostLayout at the end of optimization stage for level 3 * reformatted files * Update qiskit/transpiler/preset_passmanagers/builtin_plugins.py added suggestion for the seed Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * added release note --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
…l 3 (Qiskit#14120)" This temporarily reverts commit a8d2366 due to multiple bugs found around the implementation see Qiskit#14867 and Qiskit#14869. Sincefixing the bugs will have a large impact on the transpilation results it is better to just disable it and save the runtime overhead which has been reported in a few places (see Qiskit#14855 and the end of the discussion in Qiskit#14653). This functionality will be fixed in 2.2.0 and re-enabled there, but for the rest of the 2.1.x release series we should just leave it disabled.
…l 3 (#14120)" (#14905) * Revert "Added VF2PostLayout at the end of optimization stage for level 3 (#14120)" This temporarily reverts commit a8d2366 due to multiple bugs found around the implementation see #14867 and #14869. Sincefixing the bugs will have a large impact on the transpilation results it is better to just disable it and save the runtime overhead which has been reported in a few places (see #14855 and the end of the discussion in #14653). This functionality will be fixed in 2.2.0 and re-enabled there, but for the rest of the 2.1.x release series we should just leave it disabled. * Apply suggestions from code review Co-authored-by: Jake Lishman <jake@binhbar.com> --------- Co-authored-by: Jake Lishman <jake@binhbar.com>
Summary
Fixes #14100.
This PR adds
VF2PostLayout
with thestrict_direction
mode enabled to the end of the optimization stage for the optimization level 3.Details and comments