Skip to content

Conversation

LenaPer
Copy link
Contributor

@LenaPer LenaPer commented Mar 28, 2025

Summary

Fixes #14100.

This PR adds VF2PostLayout with the strict_direction mode enabled to the end of the optimization stage for the optimization level 3.

Details and comments

  • added the pass to the end of the optimization stage
  • updated the doc explaining the optimization level 3 accordingly

@LenaPer LenaPer requested a review from a team as a code owner March 28, 2025 12:21
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 28, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@mtreinish mtreinish added this to the 2.1.0 milestone Mar 28, 2025
@coveralls
Copy link

coveralls commented Mar 28, 2025

Pull Request Test Coverage Report for Build 15110047730

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 88.303%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 4 91.98%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 15094029635: 0.001%
Covered Lines: 78343
Relevant Lines: 88721

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this mostly looks good to me, thanks for doing this. I left one minor suggestion inline. I'm almost disappointed that no tests broke from doing this, I was kind of hoping that this would find a place where the layout could be improved.

@LenaPer
Copy link
Contributor Author

LenaPer commented Apr 23, 2025

Thanks for the feedback and the suggestion! Is there anything more I need to do on my end ?

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good @LenaPer! You could add a release note documenting the update to optimization level 3, I'd say it's a transpiler feature.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for doing this.

@mtreinish mtreinish enabled auto-merge May 19, 2025 10:17
@mtreinish mtreinish added this pull request to the merge queue May 19, 2025
Merged via the queue into Qiskit:main with commit a8d2366 May 19, 2025
24 checks passed
@eliarbel eliarbel added the Changelog: New Feature Include in the "Added" section of the changelog label Jun 3, 2025
rahaman-quantum pushed a commit to rahaman-quantum/qiskit that referenced this pull request Jun 20, 2025
…kit#14120)

* added VF2PostLayout at the end of optimization stage for level 3

* reformatted files

* Update qiskit/transpiler/preset_passmanagers/builtin_plugins.py

added suggestion for the seed

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* added release note

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Aug 14, 2025
…l 3 (Qiskit#14120)"

This temporarily reverts commit a8d2366
due to multiple bugs found around the implementation see Qiskit#14867
and Qiskit#14869. Sincefixing the bugs will have a large impact on the
transpilation results it is better to just disable it and save the runtime
overhead which has been reported in a few places (see Qiskit#14855 and the end
of the discussion in Qiskit#14653). This functionality will be fixed in 2.2.0
and re-enabled there, but for the rest of the 2.1.x release series we
should just leave it disabled.
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2025
…l 3 (#14120)" (#14905)

* Revert "Added VF2PostLayout at the end of optimization stage for level 3 (#14120)"

This temporarily reverts commit a8d2366
due to multiple bugs found around the implementation see #14867
and #14869. Sincefixing the bugs will have a large impact on the
transpilation results it is better to just disable it and save the runtime
overhead which has been reported in a few places (see #14855 and the end
of the discussion in #14653). This functionality will be fixed in 2.2.0
and re-enabled there, but for the rest of the 2.1.x release series we
should just leave it disabled.

* Apply suggestions from code review

Co-authored-by: Jake Lishman <jake@binhbar.com>

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add VF2PostLayout to the end of the default optimization stage for optimization level 3
6 participants