Move generate_preset_pass_manager to a standalone file
#12762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10073131207Details
💛 - Coveralls |
mtreinish
reviewed
Jul 11, 2024
ElePT
commented
Jul 12, 2024
releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml
Outdated
Show resolved
Hide resolved
mtreinish
reviewed
Jul 12, 2024
releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
previously approved these changes
Jul 15, 2024
|
Might we be amenable to making this name available from |
@jakelishman Makes sense to me, added path in ebb48ac. |
jakelishman
previously approved these changes
Jul 16, 2024
…erate-preset-pm-to-new-home
bc48357 to
6eb5dc0
Compare
498842b to
9069dde
Compare
|
While dealing with the cyclic imports I realized that, in #12185, I hadn't migrated two input handling functions (the ones for Now that I think of it, maybe I should open an independent PR with these fixes, it might be a bit clearer. Edit: changes extracted to #12799. |
e039638 to
6eb5dc0
Compare
mtreinish
previously approved these changes
Jul 23, 2024
releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml
Outdated
Show resolved
Hide resolved
…185f3f738b.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
approved these changes
Jul 24, 2024
ElePT
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jul 24, 2024
* Move generate_preset_pass_manager to generate_preset_pass_manager.py * Add top-level import and reno * Apply suggestions from Matt's code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Add import path from qiskit.transpiler too * Fix cyclic import issue * Fix cyclic import issue in tools/pgo_scripts * Address cyclic import issues. Reorder imports alphabetically when relevant. * Fix docstring issue * Update releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* Move generate_preset_pass_manager to generate_preset_pass_manager.py * Add top-level import and reno * Apply suggestions from Matt's code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Add import path from qiskit.transpiler too * Fix cyclic import issue * Fix cyclic import issue in tools/pgo_scripts * Address cyclic import issues. Reorder imports alphabetically when relevant. * Fix docstring issue * Update releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
generate_preset_pass_managerdeserves a proper home. This PR moves this function from the__init__file intranspiler/preset_passmanagersto a standalone file in the same directory,generate_preset_pass_manager.py.Note that this move doesn't affect the public interface or documented import path, but it makes it easier to find the source code when traversing the repo.
Details and comments
The PR now adds a global import path for
generate_preset_pass_managerand contributes to #11897.