-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Prepare for the 0.46 release #11697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for the 0.46 release #11697
Conversation
One or more of the the following people are requested to review this:
|
from qiskit.quantum_info.quaternion import Quaternion | ||
|
||
from .cnotdihedral_decompose import decompose_cnotdihedral | ||
from .clifford_decompose import decompose_clifford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that you need to add clifford_decompose and cnotdihedral_decompose, since they were deprecated in a previous release.
Quaternion was moved inside quantum_info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true, but I'm restoring them here because 0.46.0 is special. We're documenting this release as being fully compatible with 0.45.x and it's primarily about just adding the deprecation warnings for API changes coming in 1.0.0. Removing these as part of 0.46.0 would break that messaging because if someone was still using the deprecated qiskit.quantum_info.synthesis.clifford_decompose()
function when they upgraded from 0.45.2 to 0.46.0 it would break. If 0.46.0 was a normal minor version release this would have been totally fine, 0.46.0 is really just a special edge case as the last minor version in the 0.* release series.
2d2f40c
to
4c56aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a first pass on the release notes, mostly typos. One comment is that the CI artifact I used to check the rendered notes didn't seem to catch this new file, the prelude didn't show up and they were labeled as 0.45.0-34:
Anyways, the text is the same so it was still helpful, and it might have been my bad, just wanted to raise it in case it was not my bad.
28b0a6c
to
49d3550
Compare
This is an artifact of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos and lots of nitpicks 🙂
This commit prepares the 0.46.0 release, this involves 2 steps first changing all the version numbers to 0.46.0 from 0.45.x and secondly updating the release notes to prepare them for publishing. There are some larger than normal changes to the release notes made in this PR. Because of the nature of how 0.46 was developed in parallel to 0.45.x, the merge commits used to sync changes from stable/0.45 to stable/0.46 cause reno to be unable to determine which tag a release note is associated with reliably. To ensure reno is able to determine all the 0.46.0 release notes go together this commit squashes all the applicable release notes into a single new file (along with adding a prelude). As part of this process the release notes were edited for consistency and accuracy. Some other changes to note are: - The release note about the deprecation of qobj input to UnitarySimulatorPy was removed as it's been subsumed by the deprecation of UnitarySimulatorPy - The release note about the removal of the deprecated `clifford_decompose` and `cnotdihedral_decompose` was removed and those functions were restored as breaking API changes were not allowed in this release. Similarly the qiskit.synthesis.Quaternion path was restored. - Bumped the cibuildwheel version used to build wheels to v2.16.5 which is needed to fix compatibility with newer powershell releases now that the Github actions windows images bumped the powershell version installed.
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
4d06392
to
022f315
Compare
I think this is ready for review so we can tag 0.46.0 once it's merged. The only open question is if we need to do anything related to: #11512 (comment) |
I pushed up a commit that adds a timeline into all the decorators. There's other use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read the release notes fully, but looks like Elena and Julien did, and we can fix that after merge if necessary anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the renos.
Summary
This commit prepares the 0.46.0 release, this involves 2 steps first changing all the version numbers to 0.46.0 from 0.45.x and secondly updating the release notes to prepare them for publishing.
There are some larger than normal changes to the release notes made in this PR. Because of the nature of how 0.46 was developed in parallel to 0.45.x, the merge commits used to sync changes from stable/0.45 to stable/0.46 cause reno to be unable to determine which tag a release note is associated with reliably. To ensure reno is able to determine all the 0.46.0 release notes go together this commit squashes all the applicable release notes into a single new file (along with adding a prelude). As part of this process the release notes were edited for consistency and accuracy. Some other changes to note are:
clifford_decompose
andcnotdihedral_decompose
was removed and those functions were restored as breaking API changes were not allowed in this release. Similarly the qiskit.synthesis.Quaternion path was restored.Details and comments
TODO: