Summary

The standard deprecation message states that features will not be removed for 3 months after their deprecation, which is not quite true for deprecations of the 0.46 release that are removed in 1.0. We should ensure we consistently use a deprecation message phrased something like

<this feature> is deprecated since Qiskit 0.46 and will be removed in Qiskit 1.0.

This is already done in some places in quantumcircuit.py using the removal_timeline kwarg, but is not yet done in some other places such as here or here.

We should do this just before the release, such that we only need to do it once 🙂