Fix UnrollCustomDefinitions handling of empty definitions
#9899
+25
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous form of the code assumed that the `data` of the definition of a custom instruction contained the complete information. This is not the case; a definition might also have a global phase. If the definition of a custom instruction was empty but had a global phase set, this pass would silently throw it away.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
ewinston
approved these changes
Apr 3, 2023
Pull Request Test Coverage Report for Build 4599782933
💛 - Coveralls |
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
) The previous form of the code assumed that the `data` of the definition of a custom instruction contained the complete information. This is not the case; a definition might also have a global phase. If the definition of a custom instruction was empty but had a global phase set, this pass would silently throw it away.
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
) The previous form of the code assumed that the `data` of the definition of a custom instruction contained the complete information. This is not the case; a definition might also have a global phase. If the definition of a custom instruction was empty but had a global phase set, this pass would silently throw it away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous form of the code assumed that the
dataof the definition of a custom instruction contained the complete information. This is not the case; a definition might also have a global phase. If the definition of a custom instruction was empty but had a global phase set, this pass would silently throw it away.Details and comments
Fixes an issue found in #9251 (comment).