Fix exact floating-point comparison causing flaky test #9021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggered semi-reliably on Windows with all optional packages installed, with the output different by 2 ULP. It's a floating-point equality check, so what we care about asserting is approximate equality, not exact.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3345743990
💛 - Coveralls |
mtreinish
approved these changes
Oct 28, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
This triggered semi-reliably on Windows with all optional packages installed, with the output different by 2 ULP. It's a floating-point equality check, so what we care about asserting is approximate equality, not exact. (cherry picked from commit 7987742)
mergify bot
added a commit
that referenced
this pull request
Oct 28, 2022
This triggered semi-reliably on Windows with all optional packages installed, with the output different by 2 ULP. It's a floating-point equality check, so what we care about asserting is approximate equality, not exact. (cherry picked from commit 7987742) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This triggered semi-reliably on Windows with all optional packages installed, with the output different by 2 ULP. It's a floating-point equality check, so what we care about asserting is approximate equality, not exact.
Details and comments
Turned up by #8967.