Skip to content

Remove deprecated classes and methods in quantum_info #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Remove deprecated classes and methods in quantum_info #6766

wants to merge 14 commits into from

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Jul 19, 2021 •
edited
Loading

Summary

Remove

  • deprecated operators.Pauli, pauli_group
  • deprecated methods in Pauli

Details and comments

@ikkoham
Copy link
Contributor Author

ikkoham commented Jul 20, 2021

This PR requires rerun after Qiskit/qiskit-aer#1295 is merged.

@woodsp-ibm woodsp-ibm added the mod: quantum info Related to the Quantum Info module (States & Operators) label Aug 10, 2021
@ikkoham
Copy link
Contributor Author

ikkoham commented Sep 16, 2021

The CI error has already been resolved by qiskit-community/qiskit-ignis#571.
The tests use stable, so failed. What should I do? (Should I wait the release of Ignis?)

@mtreinish
Copy link
Member

The CI error has already been resolved by Qiskit/qiskit-ignis#571.
The tests use stable, so failed. What should I do? (Should I wait the release of Ignis?)

Yeah, we'll have to wait for a release of ignis. The tutorials CI job is doing it's job and catching things that would break users if they were going to upgrade to terra with this pr. If we merged this today and potentially released before ignis, anyone using the cnot dihedral rb from pypi would be broken. The ignis release is blocked on #6867 though because we're going to deprecate ignis in it's next release.

@kdk kdk added the on hold Can not fix yet label Sep 16, 2021
@ikkoham
Copy link
Contributor Author

ikkoham commented Sep 17, 2021

Thank you. Let's wait.

@coveralls
Copy link

coveralls commented Nov 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1774180430

  • 11 of 11 (100.0%) changed or added relevant lines in 7 files are covered.
  • 623 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-1.0%) to 82.184%
Files with Coverage Reduction New Missed Lines %
qiskit/algorithms/minimum_eigen_solvers/vqe.py 1 90.96%
qiskit/quantum_info/operators/symplectic/base_pauli.py 1 87.5%
qiskit/quantum_info/operators/symplectic/clifford_circuits.py 1 91.82%
qiskit/tools/parallel.py 1 59.38%
qiskit/version.py 1 77.88%
qiskit/quantum_info/operators/measures.py 2 63.36%
qiskit/quantum_info/operators/symplectic/pauli.py 2 78.26%
qiskit/result/postprocess.py 2 73.56%
qiskit/utils/arithmetic.py 2 75.32%
qiskit/init.py 3 70.97%
Totals Coverage Status
Change from base Build 1763987014: -1.0%
Covered Lines: 51180
Relevant Lines: 62275
💛 - Coveralls

@jakelishman
Copy link
Member

Are we scheduling this for Terra 0.20, since Ignis 0.7 (deprecation boogaloo) can't release until Terra 0.19?

@ikkoham
Copy link
Contributor Author

ikkoham commented Nov 15, 2021

If we release Ignis 0.7 first and then Terra 0.19, can't we include this PR in the next releases? (there are many other reasons, so if that's not possible, 0.20 is fine.)

@mtreinish
Copy link
Member

It's unfortunately not possible to sequence things that way because the release of ignis 0.7 is blocked on the terra 0.19.0 release.

@ikkoham
Copy link
Contributor Author

ikkoham commented Nov 18, 2021

Thank you. This PR should be merged for 0.20.

@ShellyGarion ShellyGarion added this to the 0.20 milestone Nov 18, 2021
@ikkoham
Copy link
Contributor Author

ikkoham commented Nov 19, 2021

A part of this PR is splitted into #7291.

Cryoris
Cryoris reviewed Jan 27, 2022
View reviewed changes
qiskit/quantum_info/operators/dihedral/dihedral.py
@@ -314,6 +313,8 @@ def to_circuit(self):
*Scalable randomised benchmarking of non-Clifford gates*,
npj Quantum Inf 2, 16012 (2016).
"""
from qiskit.quantum_info.synthesis.cnotdihedral_decompose import decompose_cnotdihedral
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this import need to be local due to some new cyclic dependency?

@Cryoris
Copy link
Contributor

Cryoris commented Jan 27, 2022

Since Ignis 0.7 was released in December, can we proceed with this PR? 🙂

@ikkoham Could you add a releasenote stating that this deprecated code is now removed? I think this is usually part of the upgrade section 🙂

@mtreinish mtreinish removed the on hold Can not fix yet label Jan 31, 2022
@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Mar 26, 2022
@kdk kdk modified the milestones: 0.20, 0.21 Mar 29, 2022
@daimurat daimurat mentioned this pull request May 16, 2022
Merged
@HuangJunye HuangJunye added the QAMP issues and PRs relating to Qiskit Advocates Mentorship Program label Jun 14, 2022
@mtreinish
Copy link
Member

I'm going to close this since it's been superseded by #8070 . If this is incorrect please feel free to reopen this.

@mtreinish mtreinish closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris left review comments

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

@manoelmarques manoelmarques Awaiting requested review from manoelmarques

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) QAMP issues and PRs relating to Qiskit Advocates Mentorship Program
Projects
None yet
Milestone
0.21
Development

Successfully merging this pull request may close these issues.
9 participants
@ikkoham @mtreinish @coveralls @jakelishman @Cryoris @kdk @HuangJunye @woodsp-ibm @ShellyGarion