Skip to content

Remove deprecated operators of BaseOperator #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 25, 2021
Merged

Remove deprecated operators of BaseOperator #7291

merged 9 commits into from
Nov 25, 2021

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Nov 19, 2021 •
edited
Loading

Summary

Remove the overloaded operators * (__mul__) for the dot method and @ (__matmul__) for the compose of BaseOperator, that is deprecated as of version 0.17.0.

Details and comments

label: mod: quantum info
milestone: 0.19

@ikkoham ikkoham requested review from chriseclectic and a team as code owners November 19, 2021 05:56
@ikkoham ikkoham mentioned this pull request Nov 19, 2021
Closed
@coveralls
Copy link

coveralls commented Nov 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1504915865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 82.792%
Files with Coverage Reduction New Missed Lines %
qiskit/quantum_info/states/quantum_state.py 1 88.0%
Totals Coverage Status
Change from base Build 1503942901: -0.002%
Covered Lines: 50013
Relevant Lines: 60408
💛 - Coveralls

@mtreinish mtreinish added Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Nov 20, 2021
@mtreinish mtreinish added this to the 0.19 milestone Nov 20, 2021
mtreinish
mtreinish reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, the release not could just use some more details I left an inline suggestion on how to improve it, but since I did it via the github web editor I assume the whitespace and stuff is all wrong (github makes it very difficult to get correct).

jakelishman
jakelishman reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any of the deprecation warning filters in qiskit/test/base.py that can be removed now that these have expired?

@ikkoham
Copy link
Contributor Author

ikkoham commented Nov 24, 2021

Are there any of the deprecation warning filters in qiskit/test/base.py that can be removed now that these have expired?

Thanks. Yes. I can remove some. ce44e6b

jakelishman
jakelishman approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a couple of issues in the release notes (for example the function random_operator doesn't exist!), but this all looks fine to me. I'm particularly glad to be getting rid of some of these extra warning ignores from the test suite.

@mergify mergify bot merged commit b74089e into Qiskit:main Nov 25, 2021
@ikkoham ikkoham deleted the qinfo/deprecated-matmul branch November 26, 2021 03:52
@jakelishman jakelishman mentioned this pull request Jan 26, 2022
Closed
@jakelishman jakelishman mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish left review comments

@jakelishman jakelishman jakelishman approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.
4 participants
@ikkoham @coveralls @mtreinish @jakelishman