Skip to content

Global phase in TwoQubitBasisDecomposer #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 3, 2021
Merged

Global phase in TwoQubitBasisDecomposer #5764

merged 8 commits into from
Feb 3, 2021

Conversation

georgios-ts
Copy link
Contributor

Summary

Correct the global phase of circuits synthesized by the TwoQubitBasisDecomposer.
Alternative for #5643 .

@georgios-ts georgios-ts requested review from chriseclectic and a team as code owners February 1, 2021 17:52
@kdk kdk mentioned this pull request Feb 2, 2021
Closed
@kdk kdk added Changelog: Bugfix Include in the "Fixed" section of the changelog global-phase labels Feb 2, 2021
@kdk kdk added this to the 0.17 milestone Feb 2, 2021
levbishop
levbishop requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@levbishop levbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Can you update TwoQubitWeylDecomposition.__repr__() to show the global phase?

levbishop
levbishop approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@levbishop levbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge as far as I am concerned. Thanks for this - I can see that it was more work than I would guessed because when I translated from mathematica I see I took some shortcuts about signs and factors of i

@mergify mergify bot merged commit 20bb390 into Qiskit:master Feb 3, 2021
@kdk kdk added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 5, 2021
mergify bot added a commit that referenced this pull request Feb 5, 2021
@georgios-ts @mergify
Global phase in TwoQubitBasisDecomposer (#5764)
7dd331a 
* global phase in TwoQubitBasisDecomposer

* bug fix and more tests

* update __repr__ and remove test

* lint

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 20bb390)
@mergify mergify bot mentioned this pull request Feb 5, 2021
Merged
mtreinish added a commit that referenced this pull request Feb 5, 2021
@mergify @georgios-ts @mtreinish
Global phase in TwoQubitBasisDecomposer (#5764) (#5791)
277b314 
* global phase in TwoQubitBasisDecomposer

* bug fix and more tests

* update __repr__ and remove test

* lint

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 20bb390)

Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@levbishop levbishop mentioned this pull request Feb 9, 2021
Merged
@kdk kdk mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdk kdk kdk approved these changes

@levbishop levbishop levbishop approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog global-phase stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@georgios-ts @kdk @levbishop