Use retworkx neighbors method in noise adaptive layout #5411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#5117 the noise adaptive layout pass was updated to use retworkx internally for performance. In that PR there were a couple of TODO comments added about using neighbors methods when they were released. The retworkx 0.6.0 release was pushed last week so we can update the usage and remove the TODO comments. The neighbors methods should have lower overhead since it only returns a list of node indices instead of a dictionary of (node index, edge weight). This will also get significantly faster (for large neighbors lists) with Qiskit/rustworkx#198.
kdk
approved these changes
Dec 8, 2020
delapuente
added a commit
to delapuente/qiskit-terra
that referenced
this pull request
Feb 15, 2021
Changes in Qiskit#5411, to use retworkx's neighbors() function, replaces the returned dict with an iterator. In the dict version, neighbor node indices are the keys and therefore, they are unique. In the iterator version, node indices appear multiple times, once per edge in multigraphs. This commit use a Python set to preserve the semantics of the old version ensuring the uniqueness of the nodes.
mergify bot
added a commit
that referenced
this pull request
Feb 15, 2021
Changes in #5411, to use retworkx's neighbors() function, replaces the returned dict with an iterator. In the dict version, neighbor node indices are the keys and therefore, they are unique. In the iterator version, node indices appear multiple times, once per edge in multigraphs. This commit use a Python set to preserve the semantics of the old version ensuring the uniqueness of the nodes. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #5117 the noise adaptive layout pass was updated to use retworkx
internally for performance. In that PR there were a couple of TODO
comments added about using neighbors methods when they were released.
The retworkx 0.6.0 release was pushed last week so we can update the
usage and remove the TODO comments. The neighbors methods should have
lower overhead since it only returns a list of node indices instead of a
dictionary of (node index, edge weight). This will also get
significantly faster (for large neighbors lists) with
Qiskit/rustworkx#198.
Details and comments