Avoid module level sympy import again #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as in Qiskit#4385 and Qiskit#3156 we should not be importing sympy at the module level. Sympy is a very heavy dependency and is slow to import (and slow to run too). Adding a sympy import to the module level makes imports significantly slower. This commit reverts the top level import of sympy, which was only added for type hints, to fix the import performance regression.
|
This was flagged in the benchmark results here: https://qiskit.github.io/qiskit/#import.QiskitImport.time_qiskit_import?machine=qiskit-benchmarking&os=Ubuntu%2018.04&ram=16%20GB&commits=1687c30f |
1ucian0
approved these changes
Sep 30, 2020
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 19, 2020
Just as has been demonstrated many times in the past we should not be importing sympy at the module level. In Qiskit#5259 another import was added and was immediately flagged as an import speed regression [1]. Sympy is a very heavy dependency and is slow to import (and slow to run too). Adding a sympy import to the module level makes and is honestly a dependency we should be reluctant to add anywhere because it becomes the primary bottleneck whenever it is used. This commit removes the top level sympy import and moves to be a runtime import in the single method that uses sympy. Just as it was done in Qiskit#5149, Qiskit#4385, and Qiskit#3156 before. [1] https://qiskit.github.io/qiskit/#import.QiskitImport.time_qiskit_import?commits=b5d5a3bb
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
Just as has been demonstrated many times in the past we should not be importing sympy at the module level. In #5259 another import was added and was immediately flagged as an import speed regression [1]. Sympy is a very heavy dependency and is slow to import (and slow to run too). Adding a sympy import to the module level makes and is honestly a dependency we should be reluctant to add anywhere because it becomes the primary bottleneck whenever it is used. This commit removes the top level sympy import and moves to be a runtime import in the single method that uses sympy. Just as it was done in #5149, #4385, and #3156 before. [1] https://qiskit.github.io/qiskit/#import.QiskitImport.time_qiskit_import?commits=b5d5a3bb Co-authored-by: Julien Gacon <gaconju@gmail.com>
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 4, 2021
Just as has been demonstrated many times in the past we should not be importing sympy at the module level. In Qiskit#5358 another import was added and was immediately flagged as an import speed regression [1]. Sympy is a very heavy dependency and is slow to import (and slow to run too). Adding a sympy import to the module level makes and is honestly a dependency we should be reluctant to add anywhere because it becomes the primary bottleneck whenever it is used. This commit removes the top level sympy import and moves to be a runtime import in the single method that uses sympy. Just as it was done in Qiskit#5416, Qiskit#5149, Qiskit#4385, and Qiskit#3156 before. Fixes Qiskit#5575 [1] https://qiskit.github.io/qiskit/#import.QiskitImport.time_qiskit_import?commits=300e9507
kdk
pushed a commit
that referenced
this pull request
Jan 4, 2021
Just as has been demonstrated many times in the past we should not be importing sympy at the module level. In #5358 another import was added and was immediately flagged as an import speed regression [1]. Sympy is a very heavy dependency and is slow to import (and slow to run too). Adding a sympy import to the module level makes and is honestly a dependency we should be reluctant to add anywhere because it becomes the primary bottleneck whenever it is used. This commit removes the top level sympy import and moves to be a runtime import in the single method that uses sympy. Just as it was done in #5416, #5149, #4385, and #3156 before. Fixes #5575 [1] https://qiskit.github.io/qiskit/#import.QiskitImport.time_qiskit_import?commits=300e9507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just as in #4385 and #3156 we should not be importing sympy at the
module level. Sympy is a very heavy dependency and is slow to import
(and slow to run too). Adding a sympy import to the module level makes
imports significantly slower. This commit reverts the top level import
of sympy, which was only added for type hints, to fix the import
performance regression.
Details and comments