Skip to content

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Apr 22, 2020

The test test.python.transpiler.test_mappers compares circuits using pickles. With this PR, that serialization is done with QASM, so the files are human-readable. This was suggested by @kdk .

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really big +1, using pickle as a general serialization format is almost never the right solution. This is much better

@mergify mergify bot merged commit 73b0ff8 into Qiskit:master Apr 23, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants