Build ibm-platform-services with known-good setuptools
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11e82ed to
fb099f5
Compare
`ibm-platform-services<=0.55.1` only supply an `sdist` on PyPI, and the `setup.py` of that sdist imports the deprecated `setuptools.commands.test`, which is removed in `setuptools==72.0.0`. This makes the package unbuildable with the latest `setuptools`, and it's hard to thread through a constraint on build dependencies right into the depths of recursive pip/tox/whatever commands. This commit forcibly builds the bad dependency with an older version of `setuptools` and adds the wheel to the pip cache, so subsequent installation commands will be able to install from a pre-built wheel regardless of the `setuptools` version.
fb099f5 to
fd11dad
Compare
ibm-platform-services with known-good setuptools
ElePT
approved these changes
Jul 29, 2024
github-merge-queue bot
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Jul 29, 2024
Copies Qiskit/qiskit-neko#48 to temporarily fix CI. --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibm-platform-services<=0.55.1only supply ansdiston PyPI, and thesetup.pyof that sdist imports the deprecatedsetuptools.commands.test, which is removed insetuptools==72.0.0. This makes the package unbuildable with the latestsetuptools, and it's hard to thread through a constraint on build dependencies right into the depths of recursive pip/tox/whatever commands.This commit forcibly builds the bad dependency with an older version of
setuptoolsand adds the wheel to the pip cache, so subsequent installation commands will be able to install from a pre-built wheel regardless of thesetuptoolsversion.