This repository was archived by the owner on Aug 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 737
Fix install from source docs #1625
Merged
mergify
merged 3 commits into
Qiskit:master
from
mtreinish:fix-terra-source-install-instructions
Nov 1, 2022
Merged
Fix install from source docs #1625
mergify
merged 3 commits into
Qiskit:master
from
mtreinish:fix-terra-source-install-instructions
Nov 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in Qiskit#1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from Qiskit#1439 so that the hosted docs correctly document how to build and install qiskit from source. Fixes Qiskit#1624
jakelishman
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, mostly this looks fine to me.
jakelishman
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
Comment on lines
-356
to
+337
5. Build and install qiskit-aer directly | ||
4. Build and install qiskit-aer directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This number only actually follows from the Linux and macOS paths (not the Windows one), but that was pre-existing anyway.
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
* Fix install from source docs In Qiskit/qiskit-metapackage#1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in Qiskit/qiskit-metapackage#1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from Qiskit/qiskit-metapackage#1439 so that the hosted docs correctly document how to build and install qiskit from source. Fixes Qiskit/qiskit-metapackage#1624 * Update docs/getting_started.rst * Remove unnecessary pip install from aer instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
automerge
This PR will automatically merge once its CI has passed
documentation
Something is not clear or error in description
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in #1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from #1439 so that the hosted docs correctly document how to build and install qiskit from source.
Details and comments
Fixes #1624