Skip to content
This repository was archived by the owner on Aug 19, 2023. It is now read-only.

Replace ignis benchmarks with qiskit-experiments #1488

Merged
merged 6 commits into from
May 5, 2022
Merged

Replace ignis benchmarks with qiskit-experiments #1488

merged 6 commits into from
May 5, 2022

Conversation

chriseclectic
Copy link
Member

Summary

I'm not really sure what the purpose of these benchmarks was for, but just replaced the existing code with something close to the same using the equivalent experiments from qiskit-experiments.

Details and comments

mtreinish
mtreinish reviewed May 4, 2022
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I think is missing is updating the asv.conf.json to replace ignis with experiments.

@mtreinish mtreinish linked an issue May 4, 2022 that may be closed by this pull request
Migriate ignis-based benchmarks to qiskit-experiments #1485
Closed
mtreinish
mtreinish reviewed May 4, 2022
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small nit inline

mtreinish
mtreinish reviewed May 4, 2022
View reviewed changes
@chriseclectic @mtreinish
Apply suggestions from code review
0b3b2ac 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@mtreinish
Copy link
Member

I tried running this locally the randomized benchmarking benchmarks work well. But the tomography benchmarks are failing:

                 File "/home/mtreinish/git/qiskit/qiskit/test/benchmarks/state_tomography.py", line 53, in time_state_tomography_cat
                   expdata.analysis_result("state")
                 File "/home/mtreinish/git/qiskit/qiskit/.asv/env/63b4d1e2919fcd950c89910ea84c38ee/lib/python3.9/site-packages/qiskit_experiments/database_service/db_experiment_data.py", line 1798, in __getattr__
                   raise AttributeError("Attribute %s is not defined" % name)
               AttributeError: Attribute analysis_result is not defined

@mtreinish mtreinish merged commit 0faaba4 into Qiskit:master May 5, 2022
@ShellyGarion ShellyGarion mentioned this pull request Jun 21, 2022
Closed
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 1, 2023
@chriseclectic @mtreinish
Replace ignis benchmarks with qiskit-experiments (Qiskit/qiskit-metap…
85929a9 
…ackage#1488)

* Replace ignis benchmarks with qiskit-experiments

* Simplify tomography benchmark

* remove ignis from asv conf

* Remove whitespace

* Apply suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Fix typo

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
@chriseclectic @mtreinish
Replace ignis benchmarks with qiskit-experiments (Qiskit/qiskit-metap…
b3a002a 
…ackage#1488)

* Replace ignis benchmarks with qiskit-experiments

* Simplify tomography benchmark

* remove ignis from asv conf

* Remove whitespace

* Apply suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Fix typo

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mtreinish mtreinish mtreinish approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migriate ignis-based benchmarks to qiskit-experiments
2 participants
@chriseclectic @mtreinish