-
Notifications
You must be signed in to change notification settings - Fork 185
Completely remove pulse defaults #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ElePT This can be part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to submit the review yesterday. I think that the changes look good, I just had a couple of minor comments.
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to see technical debt go :)
* wip remove pulse defaults * remove fake backend defaults * fix docs build * fix docs again * unit tests * cleanup unused methods * lint and reno * add warning back * Update release-notes/unreleased/2238.other.rst Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Summary
Can't merge until 3 months after
0.38.0
release ~ 7/16Details and comments
Fixes #2179