Skip to content

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 25, 2023

Changes

An extra touch of intuitiveness/developeriness for the sidebar/search area: keyboard navigation.

click

@Twixes Twixes requested a review from thmsobrmlr April 25, 2023 17:06
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Something is going on with shortcut key order, but other than that :shipit:

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit de1357d into master Apr 26, 2023
@Twixes Twixes deleted the 3000-sidebar-keyboard branch April 26, 2023 09:40
fuziontech added a commit that referenced this pull request Apr 27, 2023
* master: (37 commits)
  fix: fix sprint planning issue template (#15271)
  fix: player skip buttons only ever showed right (#15269)
  chore: bump vm2 due to CVE (#15268)
  fix(person-query): don't query persons twice if we don't need to (#15265)
  fix(ch): stop running delete jobs while clickhouse is on an older version (#15239)
  chore(recordings): use cooperative-sticky rebalance strategy (#15260)
  fix: SESSION_RECORDING_BLOB_PROCESSING_TEAMS config handling (#15247)
  fix(flags): Some UX inconsistencies (#15255)
  fix: Recording share button (#15256)
  chore(deps): Update posthog-js to 1.54.0 (#15257)
  style(3000): Support keyboard navigation in sidebar (#15237)
  feat: Add support for opening bug report via URL (#15251)
  feat: Hedgebar (#14934)
  Fixed undefined default for window select (#15249)
  fix(data-exploration): prevent leave confirmation safeguard (#15250)
  chore: remove readonly setting defaults for hogql (#15246)
  feat(hogql): refactor macros and asterisks into "resolver" (#15175)
  feat(hogql): swap out toDateTime function (#15226)
  fix(insight-timeout-state): centralize query ID (#15240)
  Fix/forgot ingestion fixes (#15238)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants