Skip to content

feat(data exploration): convert funnel correlation feedback #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2023
Merged

feat(data exploration): convert funnel correlation feedback #14971

merged 4 commits into from
Apr 6, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Apr 4, 2023 •
edited
Loading

Problem

Funnel correlations need to be converted to data exploration for feature parity.

Changes

This PR:

  • extracts the funnel correlation feedback code to a separate logic

How did you test this code?

Manual testing

@thmsobrmlr thmsobrmlr force-pushed the data-exploration-funnel-correlation-3 branch from b51e249 to 2986eed Compare April 4, 2023 16:09
@thmsobrmlr thmsobrmlr marked this pull request as ready for review April 4, 2023 16:10
@thmsobrmlr thmsobrmlr requested a review from a team April 4, 2023 17:11
@PostHog PostHog deleted a comment from posthog-bot Apr 5, 2023
@PostHog PostHog deleted a comment from posthog-bot Apr 5, 2023
@thmsobrmlr thmsobrmlr mentioned this pull request Apr 5, 2023
Merged
mariusandra
mariusandra approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could have even removed the feedback widget. Not sure anyone's still looking at it, but this is good too 👍

@thmsobrmlr thmsobrmlr merged commit 44dab49 into data-exploration-funnel-correlation-2x Apr 6, 2023
@thmsobrmlr thmsobrmlr deleted the data-exploration-funnel-correlation-3 branch April 6, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @mariusandra