Skip to content

feat(data exploration): extract funnel correlation usage logic #14975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat(data exploration): extract funnel correlation usage logic #14975

merged 3 commits into from
Apr 6, 2023

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Funnel correlations need to be converted to data exploration for feature parity.

Changes

This PR:

  • extracts the funnel correlation usage code to a separate logic

How did you test this code?

Manual testing

@thmsobrmlr thmsobrmlr marked this pull request as ready for review April 4, 2023 20:01
@thmsobrmlr thmsobrmlr requested a review from a team April 4, 2023 20:01
@thmsobrmlr thmsobrmlr mentioned this pull request Apr 5, 2023
Merged
@thmsobrmlr thmsobrmlr merged commit 57e94d3 into data-exploration-funnel-correlation-3 Apr 6, 2023
@thmsobrmlr thmsobrmlr deleted the data-exploration-funnel-correlation-4 branch April 6, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @mariusandra