Skip to content

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Apr 4, 2023

Problem

Funnel correlations need to be converted to data exploration for feature parity.

Changes

This PR:

  • extracts the funnel correlation events table code to a separate logic

How did you test this code?

Manual testing

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this looks like a good long overdue refactor 👍

})
})

// TODO: fix this test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@thmsobrmlr thmsobrmlr merged commit 2938405 into data-exploration-funnel-correlation-4 Apr 6, 2023
@thmsobrmlr thmsobrmlr deleted the data-exploration-funnel-correlation-5 branch April 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants