fix(lemon-ui): Dashed LemonDivider shouldn't be black
#14744
Conversation
There was a problem hiding this comment.
Don't forget the one below for the vertical border too!
8c0f012 to
957b9e5
Compare
4ffadc1 to
0b50dc4
Compare
0b50dc4 to
9825ba8
Compare
965eca6 to
78adee4
Compare
There was a problem hiding this comment.
A lot of the snapshots have no visible changes that I can see. I wonder if the threshold is now too low... If people start getting a lot of snapshot changes with no real changes they will likely ignore the snapshots completely, which then nullifies the point of having the snapshots. I wonder if something small like the border color accidentally changing is worth having a higher threshold so we can trust the snapshots more.
There was a problem hiding this comment.
Not sure if this is an issue with snapshots or live on your branch but it looks like the carets in Step 1 and Step 3 changed. In fact, they look the same was as the "after" shot here on production... Which seems incorrect.
6dd7400 to
26d5052
Compare
|
Okay, clearly the scope exploded here. Back to basics: just divider colors. Looks like they did actually pop up in signup page snapshots, but we must have overlooked that. |
📸 UI snapshots have been updated9 snapshot changes in total. 0 added, 9 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Not sure why this one changed but I'm guessing just a snapshot fluke?
There was a problem hiding this comment.
Yeah, this is unfortunately indicative of an actual issue where sometimes the number isn't sized properly, though this seems to be more prevalent in tests. Re-running tests.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Raquel pointed out that
LemonDivideris now black when dashed, which was not the case before. This is a regression from #14486, which changed the way the divider is colored. This regression should have been caught by UI snapshots, but we have a relatively large failure threshold set, which was supposed to avert some flakiness before.Changes
Restores the correct color of the divider. Also, we should no longer be having those reliability issues with snapshots, so reverting to the default failure threshold.