-
Notifications
You must be signed in to change notification settings - Fork 1.9k
style(3000): Implement PostHog 3000 navbar behind a feature flag #14486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📸 UI snapshots have been updated23 snapshot changes in total. 0 added, 23 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
e8fe102
to
7f9c2bf
Compare
0e777e9
to
1fe1eb6
Compare
8bc4638
to
9007a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, solid first step of Posthog 3000! Totally changes how the app feels and I'm excited about the next steps!
To nit-pick, I'd probably like to see components split up into multiple files (one component per file) and effects extracted into a logic (as per our styleguide), but I think the code here is still changing much and it'd be premature to do this now.
From a design/UX perspective I'd very much like the option to expand the navigation to icons + text.
📸 UI snapshots have been updated26 snapshot changes in total. 0 added, 26 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Good points @thmsobrmlr, refactored a bit. |
Changes
Part of project PostHog 3000, this is a very initial implementation of compact IDE-like navigation. Figma mocks.