Skip to content

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Mar 1, 2023

Changes

Part of project PostHog 3000, this is a very initial implementation of compact IDE-like navigation. Figma mocks.

localhost_8000_home

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

23 snapshot changes in total. 0 added, 23 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the posthog-3000-nav-base branch from e8fe102 to 7f9c2bf Compare March 6, 2023 11:27
@Twixes Twixes force-pushed the posthog-3000-nav-base branch from 0e777e9 to 1fe1eb6 Compare March 10, 2023 18:04
@PostHog PostHog deleted a comment from posthog-bot Mar 10, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 10, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 10, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 10, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 10, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
@Twixes Twixes force-pushed the posthog-3000-nav-base branch from 8bc4638 to 9007a30 Compare March 13, 2023 13:06
@PostHog PostHog deleted a comment from posthog-bot Mar 13, 2023
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, solid first step of Posthog 3000! Totally changes how the app feels and I'm excited about the next steps!

To nit-pick, I'd probably like to see components split up into multiple files (one component per file) and effects extracted into a logic (as per our styleguide), but I think the code here is still changing much and it'd be premature to do this now.

From a design/UX perspective I'd very much like the option to expand the navigation to icons + text.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

26 snapshot changes in total. 0 added, 26 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes
Copy link
Member Author

Twixes commented Mar 13, 2023

Good points @thmsobrmlr, refactored a bit.
Will include nav expansion in a future PR.

@Twixes Twixes merged commit d02fac3 into master Mar 13, 2023
@Twixes Twixes deleted the posthog-3000-nav-base branch March 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants