feat(capture): support LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS=* #14421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiina303
approved these changes
Feb 27, 2023
| @@ -15,6 +15,7 @@ | |||
| EVENT_PARTITION_KEYS_TO_OVERRIDE = get_list(os.getenv("EVENT_PARTITION_KEYS_TO_OVERRIDE", "")) | |||
|
|
|||
| LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS = get_list(os.getenv("LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS", "")) | |||
| LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL = "*" in LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS | |||
There was a problem hiding this comment.
Let's do this to be safe - some tokens could include * couldn't they?
Suggested change
| LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL = "*" in LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS | |
| LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL = "*" == LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS |
There was a problem hiding this comment.
LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS (declared on the line above that) is a list, already split on the comas. We're checking that one of the items in that list is "*". This way we're less finicky than a strict envvar === "*" check.
| @@ -296,7 +296,7 @@ def get_event(request): | |||
| ingestion_context = None | |||
| send_events_to_dead_letter_queue = False | |||
|
|
|||
| if token in settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS: | |||
| if settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL or token in settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS: | |||
There was a problem hiding this comment.
I'd even just do it here since it's only used in a single place anyway
Suggested change
| if settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL or token in settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS: | |
| if settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ALL == '*' or token in settings.LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS: |
There was a problem hiding this comment.
This is executed for each event, that's why I deemed it better to check the condition once at startup.
fuziontech
added a commit
that referenced
this pull request
Feb 28, 2023
* master: (53 commits) fix: cut the undeterministic snapshots (#14461) feat(hogql): Events table based on hogql (#14315) fix(breakdown): ensure breakdown sort can sort through values of different types (#14459) feat(capture): gracefully catch non-string tokens (#14453) chore(plugin-server): add healthcheck logging for failure (#14455) fix(tests): Safer migrations (#14452) revert: "fix(person-overrides): add constraints to catch race conditions" (#14445) dev(codespaces): update to python3.10 (#14449) chore(deps): Update posthog-js to 1.50.0 (#14448) feat(capture): support LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS=* (#14421) chore: upgrade d3 (#14442) fix(person-overrides): add constraints to catch race conditions (#14277) feat(cohorts): Remove postgres calculations for flags (#14272) feat(capture): check token shape before team resolution too (#14439) feat: dashboard templates (#14322) feat: add a 'What's New?' button to the dropdown (#14379) chore(recordings): don't DLQ on PostgreSQL errors (#14438) chore: update autocapture attribute capture (#14435) chore(recordings): remove hub dependency on recordings ingestion (#14418) chore(deps): Update posthog-js to 1.49.0 (#14436) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #14329
Changes
Support setting
LIGHTWEIGHT_CAPTURE_ENDPOINT_ENABLED_TOKENS=*to enable lightweight capture on all tokens without further code changes.We'll remove the PG lookup in a follow-up PR.
How did you test this code?