Skip to content

Conversation

lixin9311
Copy link
Contributor

Fix build phase script for xcode 15+

I don't know from which version the script breaks.
Let's assume 15 for now.

New script:

# Type a script or drag a script file from your workspace to insert its path.
set -euo pipefail

IDENTITY=${EXPANDED_CODE_SIGN_IDENTITY_NAME};
# Apple Development: XIN LI (33X85HBRP6)
echo Signing identity $IDENTITY;

codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework/PlugIns/AKInterface.bundle;
codesign --verbose --force --deep --sign "$IDENTITY" ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/PlayTools.framework;

# sign sparkle
if [ "$XCODE_VERSION_MAJOR" -ge "1500" ]; then
	LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework";
	echo Sparkle Signing location $LOCATION;
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc";
else
	LOCATION="${BUILD_DIR%Build/*}SourcePackages/artifacts/sparkle/Sparkle.xcframework/macos-arm64_x86_64/Sparkle.framework";
	echo Sparkle Signing location $LOCATION;
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Autoupdate";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/Updater.app";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Downloader.xpc";
	codesign --verbose --force --deep -o runtime --sign "$IDENTITY" "$LOCATION/XPCServices/Installer.xpc";
fi

@TheMoonThatRises TheMoonThatRises merged commit d7ac538 into develop Feb 14, 2024
@lixin9311 lixin9311 deleted the fix/xcode-15 branch February 21, 2024 05:57
JoseMoreville added a commit that referenced this pull request Jul 2, 2024
* Update 1.build_release.yml (#1266)

* Add catch-all options to APP- and GAME-SUPPORT and append chip models to README (#1268)

* Add chip models to README.md

* Add catch-all options to APP- and GAME-SUPPORT

* Update 1.build_release.yml

* Update 1.build_release.yml

* Update 1.build_release.yml

* fix file name (#1285)

* revert build file + fix deprecation (#1288)

* revert build file + fix deprecation

* add back installs

* fix xcode archive shows in "Other items"

* Fix: solve nightly release warning in Action (#1346)

* fix: update action & artifact version

* chore: update checkout version.

* chore: update checkout & artifact version.

* Chnage phase to remove quarantine

* fix codesign script for xcode 15 (#1385)

* fix: make observation of modifier keys centralized (#1384)

* update macos runners + add back notarisation (#1386)

* add python and node setup to actions

* pass `GITHUB_TOKEN` as `GITHUB_ACCESS_TOKEN` env

* fix ci target macos-14

* fix codesign script, again

* fix ci pipelines again (#1397)

* Added Italian Localizable.strings

* fix subdirectory recursion

* Adopt asynchronous methods to avoid UI blocking (#1274)

* Modify PlayTools injection/removal methods to execute asynchronously to prevent UI blocking

* Added async support for the two functionalities of "Insert Introspection libraries" and "Force Insert iOS Frameworks".

* Add async support for "Clear App Data" button.

* Add async support for app uninstaller.

* Polish the UI and simplify the code.

* Fixed an issue that may cause BypassesView to load unnecessary tasks.

* Simplify code with a modern Swift concurrency version of method `beginSheetModal`  in NSAlert.

* Refactor Shell.signApp method to async.

* Fix localization (#1498)

* fix xcodeproj

* Update Localizable.strings

* Translations update from Hosted Weblate (#1298)

* Translated using Weblate (Turkish)

Currently translated at 96.9% (258 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/tr/
Translation: PlayCover/PlayCover

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 88.3% (235 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/pt_BR/
Translation: PlayCover/PlayCover

* Translated using Weblate (German)

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (German)

Currently translated at 100.0% (266 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: SkyrilHD <skyrilhd@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/de/
Translation: PlayCover/PlayCover

* Translated using Weblate (Danish)

Currently translated at 87.9% (234 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/da/
Translation: PlayCover/PlayCover

* Translated using Weblate (Russian)

Currently translated at 99.6% (265 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ru/
Translation: PlayCover/PlayCover

* Translated using Weblate (Romanian)

Currently translated at 60.1% (160 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ro/
Translation: PlayCover/PlayCover

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (0 of 0 strings)

Added translation using Weblate (Ukrainian)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/uk/
Translation: PlayCover/PlayCover

* Translated using Weblate (Japanese)

Currently translated at 88.7% (236 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ja/
Translation: PlayCover/PlayCover

* Added translation using Weblate (Catalan)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Weblate <noreply@weblate.org>

* Translated using Weblate (Vietnamese)

Currently translated at 100.0% (266 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/vi/
Translation: PlayCover/PlayCover

* Translated using Weblate (Hindi)

Currently translated at 74.4% (198 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/hi/
Translation: PlayCover/PlayCover

* Added translation using Weblate (Italian)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Weblate <noreply@weblate.org>

* Added translation using Weblate (Arabic)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Weblate <noreply@weblate.org>

* Translated using Weblate (Indonesian)

Currently translated at 73.9% (199 of 269 strings)

Translated using Weblate (Indonesian)

Currently translated at 72.4% (195 of 269 strings)

Translated using Weblate (Indonesian)

Currently translated at 71.8% (191 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Ariq Pradipa Santoso <ariq.pradipa@outlook.com>
Co-authored-by: Depa Panjie Purnama <depa.article@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/id/
Translation: PlayCover/PlayCover

* Translated using Weblate (Spanish)

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (Spanish)

Currently translated at 100.0% (266 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/es/
Translation: PlayCover/PlayCover

* Translated using Weblate (French)

Currently translated at 83.4% (222 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fr/
Translation: PlayCover/PlayCover

* Translated using Weblate (Persian)

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (Persian)

Currently translated at 75.5% (201 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Morteza Gharedaghi <morteza.ghrdi@gmail.com>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/fa/
Translation: PlayCover/PlayCover

* Translated using Weblate (Korean)

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (Korean)

Currently translated at 99.6% (265 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/ko/
Translation: PlayCover/PlayCover

* Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (266 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: Sherry Lo <yuetyeelo2855@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hant/
Translation: PlayCover/PlayCover

* Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (269 of 269 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (266 of 266 strings)

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: weng weng <carlchina@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/
Translate-URL: https://hosted.weblate.org/projects/playcover/playcover/zh_Hans/
Translation: PlayCover/PlayCover

* Italian

#1498

---------

Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: SkyrilHD <skyrilhd@gmail.com>
Co-authored-by: Ariq Pradipa Santoso <ariq.pradipa@outlook.com>
Co-authored-by: Depa Panjie Purnama <depa.article@gmail.com>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-authored-by: Morteza Gharedaghi <morteza.ghrdi@gmail.com>
Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
Co-authored-by: Sherry Lo <yuetyeelo2855@gmail.com>
Co-authored-by: weng weng <carlchina@gmail.com>
Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>

* Added PUBG India to prohibited apps

* Fix SwiftLint and disable SwiftLint non_optional_string_data_conversion (#1514)

* Fix Opening Brace Spacing Violation

* Disable SwiftLint rule non_optional_string_data_conversion

* Make notch detection work without hard-coded model list

* Added store app icon load timeout (#1207)

* Added store app icon load timeout

* IPA library app info (#1176)

* feat: ipa library app info

* remove duplicate localisations

* Google drive hosted IPA (#1472)

* Google Drive hosted IPA

* Rebase

* Fix Compile Error

* completionHandler and dispatchGroup

Find a better way (maybe still not the best) to wait redirect and scripting to end

* Moved redirectHendler

Moved functions to StoreAppView and reverted "url" variable to "let"

* fix project GD file Error

fixed also format error

* Delete all changes on Downloader.swift

* Moved GoogleDrive.swift

* add timeout on GD requests

* fix missing file from repo

* fix carthage (again)

* fix build (again)

* required modification

* Removed (null) files reference and fixed swiftlint

* Added SwiftSoup to Package Dependencies

* Change SwiftSoup version

this should fix build error

* Revert change to cartfile files

* Access modifiers changes

Making all variable and function private

* Added support for personal drive

Added support for shared link for personal google drive IPA
( Link must be like "https://drive.google.com/file/d/FILE_ID/view?usp=share_link" )

* Changes

- support to https://drive.usercontent.google.com/download?id={FileID}&export=download
- changed SwiftSoup to a lighter forked version

* Update clearPlayChain (#1499)

Add DB files to clearPlayChain as introduced in PlayCover/PlayTools#140

* Add support for iPhone 15 Pro Max and 13" M4 iPad Pro (#1470)

* Add support for iPhone 15 Pro Max and 13" M4 iPad Pro

* Change RAM iPad M4

---------

Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>

* PlayTools v3.0.0 and Build Number Bump (#1541)

* update issue templates

---------

Co-authored-by: José Moreno <47700212+JoseMoreville@users.noreply.github.com>
Co-authored-by: Xyct <87l46110@gmail.com>
Co-authored-by: TheMoonThatRises <58153205+TheMoonThatRises@users.noreply.github.com>
Co-authored-by: lucas lee <lixin9311@gmail.com>
Co-authored-by: Monet Lee <monet_lee@163.com>
Co-authored-by: Ryu-ga <frech5679@icloud.com>
Co-authored-by: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Co-authored-by: Sinon <34333654+Catta1997@users.noreply.github.com>
Co-authored-by: Stv.X <30586070+Stv-X@users.noreply.github.com>
Co-authored-by: Weblate (bot) <hosted@weblate.org>
Co-authored-by: Prefill add-on <noreply-addon-prefill@weblate.org>
Co-authored-by: SkyrilHD <skyrilhd@gmail.com>
Co-authored-by: Ariq Pradipa Santoso <ariq.pradipa@outlook.com>
Co-authored-by: Depa Panjie Purnama <depa.article@gmail.com>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-authored-by: Morteza Gharedaghi <morteza.ghrdi@gmail.com>
Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
Co-authored-by: Sherry Lo <yuetyeelo2855@gmail.com>
Co-authored-by: weng weng <carlchina@gmail.com>
Co-authored-by: Mitchell Mebane <mitchell.mebane@gmail.com>
Co-authored-by: Adam C <66894537+Wind-Explorer@users.noreply.github.com>
Co-authored-by: FlyMeToTheMoonAndLetMePlayAmongTheStars <78054566+FlyMeToTheMoonAndLetMePlayAmongTheStars@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants