Use Application ID when storing apps #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This was
linked to
issues
Nov 8, 2023
XuYicong
approved these changes
Nov 30, 2023
XuYicong
added a commit
that referenced
this pull request
Dec 9, 2023
* fix: sidebar button * Add toggle for scroll wheel (#1215) * Add * Add i18n string * fix: missing semi-colon in en localisation * Use Application ID when storing apps (#1100) * feat: init of using app id * fix: discord rpc * add and move alias function * update bundleid cache * fix cache prune * fix merge * fix removing wrong file * move create-dmg to brew --------- Co-authored-by: Xyct <87l46110@gmail.com> Co-authored-by: ytai <653297351@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1130.
This switches from using the name of the application to using the ID of the application, which should be unique and exists for every app. This fixes the problem with Mobile Legends (#668) where the character
:causes unintentional issues with the application, which could also affect other apps with unique symbols (e.g. #1104).This update will also refactor the way applications are stored in the PlayCover container (
~/Library/Containers/io.playcover.PlayCover), storing them all under one directory. The PR will also change the way certain behind-the-scenes functionality will work (and fix them), such as:To also decrease confusion as to which application is being launched, every app will have an alias created by default (under
~/Applications/PlayCover) with the display name of the application, and PlayCover will launch apps via the alias.Todo list:
Features that could be implemented in this PR but currently isn't:
All the features in this PR are subject to change and are not final.