Skip to content

chore: apply native_constant_invocation for build-in consts #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 13, 2025
Merged

chore: apply native_constant_invocation for build-in consts #8837

merged 8 commits into from
Jul 13, 2025

Conversation

keradus
Copy link
Member

@keradus keradus commented Jul 12, 2025

No description provided.

@keradus keradus mentioned this pull request Jul 12, 2025
Merged
@gharlan
Copy link
Member

gharlan commented Jul 13, 2025

I made a quick comparison by just running the fixer on this repo (disabled cache):

sequentialparallel
Run 1Run 2Run 1Run 2
master67.145 sec66.565 sec13.262 sec12.770 sec
this pr65.709 sec65.018 sec12.552 sec12.281 sec

So overall it seems to be a bit faster.
I think it is a good change. 👍 The constants are used in this repo in so many places, and it enables other improvements (#8836). Also we do not have to think about the differences of arrays containing these constants and other arrays anymore (see also #8836).

keradus added a commit to keradus/PHP-CS-Fixer that referenced this pull request Jul 13, 2025
@keradus
CS: configure native_constant_invocation
6b4e719 
follows-up for PHP-CS-Fixer#8837
@keradus keradus mentioned this pull request Jul 13, 2025
Merged
@keradus keradus changed the title apply Native constant invocation for build-in consts chore: apply native_constant_invocation for build-in consts Jul 13, 2025
@keradus keradus marked this pull request as ready for review July 13, 2025 21:36
@keradus keradus merged commit adf9503 into PHP-CS-Fixer:master Jul 13, 2025
18 of 27 checks passed
@keradus keradus deleted the native_constant_invocation__ branch July 13, 2025 21:37
@mvorisek mvorisek mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keradus @gharlan