use k3s_install_dir instead of hardcoded /usr/local/bin path to install k3s-killall.sh and k3s-uninstall.sh #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af66904 to
5c9c8aa
Compare
|
I am not sure what is wrong with the CI |
|
hey @matteyeux I had the exact same change submitted before, if you want to take over :) |
|
@matteyeux can you please rebase your changes on main? I have fixed the CI, Thanks. |
…ll k3s-killall.sh and k3s-uninstall.sh
onedr0p
approved these changes
Jul 11, 2025
|
Done @onedr0p |
JesusMtnez
pushed a commit
to JesusMtnez/homelab
that referenced
this pull request
Aug 3, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [xanmanning.k3s](https://github.com/PyratLabs/ansible-role-k3s) | role | minor | `v3.4.4` -> `v3.5.0` | --- ### Release Notes <details> <summary>PyratLabs/ansible-role-k3s (xanmanning.k3s)</summary> ### [`v3.5.0`](https://github.com/PyratLabs/ansible-role-k3s/releases/tag/v3.5.0) [Compare Source](PyratLabs/ansible-role-k3s@v3.4.4...v3.5.0) #### What's Changed - add k3s\_service\_exec\_start\_pre\_vars for the k3s service by [@​longns1](https://github.com/longns1) in PyratLabs/ansible-role-k3s#226 - Fix node registration ip on dual stack by [@​logan2211](https://github.com/logan2211) in PyratLabs/ansible-role-k3s#230 - Check for cgroup v2 controllers by [@​ToroNZ](https://github.com/ToroNZ) in PyratLabs/ansible-role-k3s#233 - ci: fix tests, update workflow deps and tested platforms by [@​onedr0p](https://github.com/onedr0p) in PyratLabs/ansible-role-k3s#238 - use k3s\_install\_dir instead of hardcoded /usr/local/bin path to install k3s-killall.sh and k3s-uninstall.sh by [@​matteyeux](https://github.com/matteyeux) in PyratLabs/ansible-role-k3s#235 #### New Contributors - [@​longns1](https://github.com/longns1) made their first contribution in PyratLabs/ansible-role-k3s#226 - [@​logan2211](https://github.com/logan2211) made their first contribution in PyratLabs/ansible-role-k3s#230 - [@​ToroNZ](https://github.com/ToroNZ) made their first contribution in PyratLabs/ansible-role-k3s#233 **Full Changelog**: PyratLabs/ansible-role-k3s@v3.4.4...v3.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4zIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwL21pbm9yIl19--> Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/769 Co-authored-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com> Co-committed-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use k3s_install_dir instead of hardcoded /usr/local/bin path to install k3s-killall.sh and k3s-uninstall.sh
Fixes #234
Issue type
Test instructions
Change
k3s_install_dirto something else, verify that k3s-killall.sh and k3s-uninstall.sh are copied to the said directory.Additional Information
If the directory does not exist, install will fail. Do you think I should create the directory first ?