Add scan for running control nodes when choosing primary control node #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e4d529 to
054ebe5
Compare
Signed-off-by: Thomas Matysik <thomas@matysik.co.nz>
054ebe5 to
ef37e60
Compare
onedr0p
approved these changes
Jan 26, 2024
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jan 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [xanmanning.k3s](https://github.com/PyratLabs/ansible-role-k3s) | role | patch | `v3.4.3` -> `v3.4.4` | --- ### Release Notes <details> <summary>PyratLabs/ansible-role-k3s (xanmanning.k3s)</summary> ### [`v3.4.4`](https://github.com/PyratLabs/ansible-role-k3s/releases/tag/v3.4.4) [Compare Source](PyratLabs/ansible-role-k3s@v3.4.3...v3.4.4) #### What's Changed - Containerd registries config not live by [@​sm-gravid-day](https://github.com/sm-gravid-day) in PyratLabs/ansible-role-k3s#222 - kubectl commands on node must use short name by [@​fragpit](https://github.com/fragpit) in PyratLabs/ansible-role-k3s#220 - Add scan for running control nodes when choosing primary control node by [@​paradon](https://github.com/paradon) in PyratLabs/ansible-role-k3s#219 #### New Contributors - [@​sm-gravid-day](https://github.com/sm-gravid-day) made their first contribution in PyratLabs/ansible-role-k3s#222 - [@​paradon](https://github.com/paradon) made their first contribution in PyratLabs/ansible-role-k3s#219 **Full Changelog**: PyratLabs/ansible-role-k3s@v3.4.3...v3.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/341 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Jan 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [xanmanning.k3s](https://togithub.com/PyratLabs/ansible-role-k3s) | role | patch | `v3.4.3` -> `v3.4.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>PyratLabs/ansible-role-k3s (xanmanning.k3s)</summary> ### [`v3.4.4`](https://togithub.com/PyratLabs/ansible-role-k3s/releases/tag/v3.4.4) [Compare Source](https://togithub.com/PyratLabs/ansible-role-k3s/compare/v3.4.3...v3.4.4) #### What's Changed - Containerd registries config not live by [@​sm-gravid-day](https://togithub.com/sm-gravid-day) in [https://github.com/PyratLabs/ansible-role-k3s/pull/222](https://togithub.com/PyratLabs/ansible-role-k3s/pull/222) - kubectl commands on node must use short name by [@​fragpit](https://togithub.com/fragpit) in [https://github.com/PyratLabs/ansible-role-k3s/pull/220](https://togithub.com/PyratLabs/ansible-role-k3s/pull/220) - Add scan for running control nodes when choosing primary control node by [@​paradon](https://togithub.com/paradon) in [https://github.com/PyratLabs/ansible-role-k3s/pull/219](https://togithub.com/PyratLabs/ansible-role-k3s/pull/219) #### New Contributors - [@​sm-gravid-day](https://togithub.com/sm-gravid-day) made their first contribution in [https://github.com/PyratLabs/ansible-role-k3s/pull/222](https://togithub.com/PyratLabs/ansible-role-k3s/pull/222) - [@​paradon](https://togithub.com/paradon) made their first contribution in [https://github.com/PyratLabs/ansible-role-k3s/pull/219](https://togithub.com/PyratLabs/ansible-role-k3s/pull/219) **Full Changelog**: PyratLabs/ansible-role-k3s@v3.4.3...v3.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTIuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scan for running existing control nodes when choosing primary control node
Summary
Current behaviour in cluster deployment is to choose the first listed control node as the 'primary',
which runs the cluster initialization.
If the first listed node is new to an existing cluster (or is being reinstalled), current behaviour will
cause this node to initialize a new cluster instead of joining the existing cluster.
This PR adds a check for any control nodes currently running the API service, and if so, it will
chose the first of these as the primary control node.
Fixes #210