Fix rate control for AMD cards using VAAPI #2821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2821 +/- ##
======================================
Coverage 8.98% 8.99%
======================================
Files 95 95
Lines 17304 17310 +6
Branches 8232 8234 +2
======================================
+ Hits 1555 1557 +2
- Misses 12884 12888 +4
Partials 2865 2865
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
e8f6f7c to
e2c27c2
Compare
|
Great to see this merged so quickly! Looking forward to the next release. 😊 |
|
I was getting the "Number of fragments for reed solomon exceeds DATA_SHARDS_MAX" error previously but not with this fix. It has made a nice performance improvement, particularly when using HDR. |
2 tasks
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Oct 9, 2024
10 tasks
c2vi
pushed a commit
to c2vi/Sunshine
that referenced
this pull request
Mar 27, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intel needs RC buffer size unset for their H.264 encoder to avoid horrible encoding quality, however this causes issues for AMD cards overshooting the expected maximum frame size and causing packet loss. Resolve this by adding a new hook in
avcodec_encode_device_tto allow the platform encoding code to set additional options on the codec context and using the vendor string to distinguish Intel cards.Screenshot
Issues Fixed or Closed
Fixes #2788
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.