Skip to content

Revert "Add capture using WinRT Windows.Graphics.Capture API." #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

Revert "Add capture using WinRT Windows.Graphics.Capture API." #2320

merged 1 commit into from
Mar 29, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 29, 2024 •
edited
Loading

Description

Reverts #2149

Due to many bugs, such as:

  • high cpu usage
  • high ram usage
  • UAC prompt not able to trigger (starting Sunshine from start menu icon)

These issues are likely caused by changing from MINGW64 to UCRT64, or possibly from changing from C++17 to C++20.

@tez011 FYI. I think we should break your PR into two parts, or maybe 3 parts.

  1. Change from C++17 to C++20
  2. Change from MINGW64 to UCRT64
  3. New feature

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.19672% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 6.10%. Comparing base (3b6a59a) to head (9f84bbf).

Additional details and impacted files 
@@           Coverage Diff            @@
##           nightly   #2320    +/-   ##
========================================
  Coverage     6.09%   6.10%            
========================================
  Files           86      85     -1     
  Lines        18518   18300   -218     
  Branches      8404    8316    -88     
========================================
- Hits          1129    1117    -12     
+ Misses       16262   16076   -186     
+ Partials      1127    1107    -20
Flag Coverage Δ
Linux 4.11% <ø> (ø)
Windows 1.51% <8.19%> (-0.07%) ⬇️
macOS-12 8.12% <ø> (ø)
macOS-13 7.44% <ø> (-0.02%) ⬇️
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/platform/windows/display.h 2.17% <ø> (ø)
src/platform/windows/input.cpp 0.39% <0.00%> (ø)
src/platform/windows/display_ram.cpp 0.96% <33.33%> (+<0.01%) ⬆️
src/platform/windows/display_vram.cpp 1.29% <33.33%> (-0.29%) ⬇️
src/platform/windows/misc.cpp 1.07% <0.00%> (ø)
src/platform/windows/display_base.cpp 9.24% <5.76%> (-0.68%) ⬇️

... and 5 files with indirect coverage changes

@ReenigneArcher ReenigneArcher marked this pull request as draft March 29, 2024 14:01
@tez011 tez011 mentioned this pull request Mar 29, 2024
Merged
11 tasks
@tez011
Copy link
Contributor

tez011 commented Mar 29, 2024

I like the plan. Can we pursue C++20 for all platforms, not just Windows, if it's being done in isolation?

Then I suppose I should start with two pull requests:

  • C++20
  • UCRT64

and if both are merged with no issue, THEN I can apply the WGC change, which depends on both.

@tez011
Copy link
Contributor

tez011 commented Mar 29, 2024

@ReenigneArcher I can start once you merge this revert.

@ReenigneArcher
Copy link
Member Author

Okay, thanks for your understanding.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 29, 2024 16:43
@ReenigneArcher ReenigneArcher merged commit 2af0ce3 into nightly Mar 29, 2024
@ReenigneArcher ReenigneArcher deleted the revert-2149-winrt-capture branch March 29, 2024 16:43
This was referenced Mar 29, 2024
Merged
Merged
qiin2333 added a commit to qiin2333/Sunshine-Foundation that referenced this pull request Mar 30, 2024
@qiin2333
Reapply "Add capture using WinRT Windows.Graphics.Capture API." (Liza…
d2e69ad 
…rdByte#2320)

This reverts commit 2af0ce3.
qiin2333 added a commit to qiin2333/Sunshine-Foundation that referenced this pull request Apr 3, 2024
@qiin2333
Revert "Reapply "Add capture using WinRT Windows.Graphics.Capture API…
6b78fc5 
…." (LizardByte#2320)"

This reverts commit d2e69ad.
@ReenigneArcher ReenigneArcher mentioned this pull request May 27, 2024
Merged
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
@ReenigneArcher
Revert "Add capture using WinRT Windows.Graphics.Capture API." (Lizar…
f32798c 
…dByte#2320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReenigneArcher @tez011