Skip to content

Conversation

ReenigneArcher
Copy link
Member

Description

  • Added CHANGELOG.md
  • Add build checks
  • Add automated release
    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
-Checkout recursively with submodules
-recursive submodules
-only run on PR for master or nightly branch
-Add deb job with matrix strategy
-build with -u for non interactive
-Fix command that moves deb package
-Separate setup, build, and package steps
-Fix permission denied error when moving deb package
-Fix path issue for pacman command
-Install boost
-Remove boost debug during cmake
-Fix boost install directory
-Add environment variable BOOST_ROOT
-Try older version of boost, new version failing with cmake 3.22
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Jan 11, 2022

I apologize for all the commits. Workflows are not the easiest thing to test.

Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353

And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817

And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases

@ReenigneArcher
Copy link
Member Author

This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.

@ReenigneArcher ReenigneArcher marked this pull request as draft January 11, 2022 21:52
-Fix typo in Windows build
- github.base_ref is needed for pull request check
-Verify changelog requires checkout
@ReenigneArcher
Copy link
Member Author

Updated Examples:

PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094
-No check on CHANGELOG.md
-Build each version
-Package everything except Fedora
-Upload artifacts

PR into master branch
When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1
-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)
-Build each version
-Package everything except Fedora
-Upload artifacts

Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2
-Same as attempt 1 except workflow passes beyond changelog check

push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883

  • Harder to fix anything at this point so:
    • The check on changelog is done earlier when the PR is made into master

Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0

@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 12, 2022 00:37
@TheElixZammuto
Copy link
Member

Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants