-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add install scripts (Flatpak) #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
v0.15.0 resubmit
v0.15.0 resubmit
v0.15.0 resubmit
Update dev.lizardbyte.sunshine.yml
Update dev.lizardbyte.sunshine.yml
Add files via upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change request to simplify it a bit.
Can you also update the docs on how to use these?
Thanks!
docs/source/about/installation.rst
Outdated
Sunshine Service | ||
|
||
.. code-block:: bash | ||
|
||
systemctl --user start sunshine | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already covered in the usage
page. I probably wouldn't add it here since we don't have it for the other linux versions.
docs/source/about/installation.rst
Outdated
@@ -104,17 +104,17 @@ Flatpak Package | |||
:alt: GitHub issues by-label | |||
|
|||
#. Install `Flatpak <https://flatpak.org/setup/>`_ as required. | |||
#. Download ``sunshine.flatpak`` and run the following code. | |||
#. Download ``sunshine_x86_64.flatpak`` and run the following code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download ``sunshine_{arch}.flatpak`` and run the following code.
.. Note:: Be sure to replace ``{arch}`` with the architecture for your operating system.
docs/source/about/installation.rst
Outdated
|
||
System level (recommended) | ||
.. code-block:: bash | ||
|
||
flatpak install --system sunshine.flatpak | ||
flatpak install --system ./sunshine_x86_64.flatpak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sunshine_{arch}.flatpak
docs/source/about/installation.rst
Outdated
|
||
User level | ||
.. code-block:: bash | ||
|
||
flatpak install --user sunshine.flatpak | ||
flatpak install --user ./sunshine_x86_64.flatpak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sunshine_{arch}.flatpak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested.
Also, is it possible to have a single script with arguments, like the AppRun for AppImage? https://github.com/LizardByte/Sunshine/blob/master/packaging/linux/AppImage/AppRun
If not, no issue with having two scripts.
Additional installation (required) | ||
.. code-block:: bash | ||
|
||
flatpak run --command=additional-install.sh dev.lizardbyte.sunshine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this code to each sub section (system and user level) instead of making a new sub section.
And if you agree to rename the scripts, change the name here as well.
@@ -0,0 +1,13 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just rename to install.sh
?
@@ -0,0 +1,11 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just rename to remove.sh
?
@@ -130,7 +137,8 @@ Start: | |||
Uninstall: | |||
.. code-block:: bash | |||
|
|||
flatpak uninstall --delete-data sunshine.flatpak | |||
flatpak run --command=remove-additional-install.sh dev.lizardbyte.sunshine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you agree to rename the scripts, change the name here as well.
Description
Add install script for mouse permission.
Type of Change
Checklist