Skip to content

Add install scripts (Flatpak) #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Nov 18, 2022
Merged

Add install scripts (Flatpak) #471

merged 48 commits into from
Nov 18, 2022

Conversation

istori1
Copy link
Contributor

@istori1 istori1 commented Nov 2, 2022

Description

Add install script for mouse permission.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@istori1 istori1 marked this pull request as draft November 2, 2022 11:27
@istori1 istori1 marked this pull request as ready for review November 3, 2022 21:48
@istori1 istori1 changed the title Add install script Add install scripts (Flatpak) Nov 3, 2022
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request to simplify it a bit.

Can you also update the docs on how to use these?

Thanks!

Comment on lines 132 to 137
Sunshine Service

.. code-block:: bash

systemctl --user start sunshine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered in the usage page. I probably wouldn't add it here since we don't have it for the other linux versions.

@@ -104,17 +104,17 @@ Flatpak Package
:alt: GitHub issues by-label

#. Install `Flatpak <https://flatpak.org/setup/>`_ as required.
#. Download ``sunshine.flatpak`` and run the following code.
#. Download ``sunshine_x86_64.flatpak`` and run the following code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download ``sunshine_{arch}.flatpak`` and run the following code.

.. Note:: Be sure to replace ``{arch}`` with the architecture for your operating system.


System level (recommended)
.. code-block:: bash

flatpak install --system sunshine.flatpak
flatpak install --system ./sunshine_x86_64.flatpak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sunshine_{arch}.flatpak


User level
.. code-block:: bash

flatpak install --user sunshine.flatpak
flatpak install --user ./sunshine_x86_64.flatpak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sunshine_{arch}.flatpak

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

Also, is it possible to have a single script with arguments, like the AppRun for AppImage? https://github.com/LizardByte/Sunshine/blob/master/packaging/linux/AppImage/AppRun

If not, no issue with having two scripts.

Comment on lines +121 to +124
Additional installation (required)
.. code-block:: bash

flatpak run --command=additional-install.sh dev.lizardbyte.sunshine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this code to each sub section (system and user level) instead of making a new sub section.

And if you agree to rename the scripts, change the name here as well.

@@ -0,0 +1,13 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just rename to install.sh ?

@@ -0,0 +1,11 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just rename to remove.sh?

@@ -130,7 +137,8 @@ Start:
Uninstall:
.. code-block:: bash

flatpak uninstall --delete-data sunshine.flatpak
flatpak run --command=remove-additional-install.sh dev.lizardbyte.sunshine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree to rename the scripts, change the name here as well.

@ReenigneArcher ReenigneArcher merged commit 4c1371a into LizardByte:nightly Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants