Skip to content

build(cmake): bump c++ to 23 #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Conversation

ReenigneArcher
Copy link
Member

Description

This PR moves Sunshine, tools, and tests to CXX 23. This is being done in order to make sonar cloud warnings more relevant as often the warnings apply only to c++23 or newer, and some contributors may end up creating bugs by fixing those warnings for sonar.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.31%. Comparing base (31f87bb) to head (e261cd2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4096   +/-   ##
=======================================
  Coverage   11.31%   11.31%           
=======================================
  Files          92       92           
  Lines       17571    17571           
  Branches     8239     8239           
=======================================
  Hits         1989     1989           
  Misses      14901    14901           
  Partials      681      681           
Flag Coverage Δ
Linux-AppImage 11.02% <ø> (ø)
Windows-AMD64 12.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the build/cmake/bump-c++-to-23 branch from 62aab03 to e261cd2 Compare July 19, 2025 12:06
Copy link

Copy link

codecov bot commented Jul 19, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher mentioned this pull request Jul 19, 2025
11 tasks
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 19, 2025 12:44
@ReenigneArcher ReenigneArcher merged commit 274b998 into master Jul 19, 2025
50 checks passed
@ReenigneArcher ReenigneArcher deleted the build/cmake/bump-c++-to-23 branch July 19, 2025 13:00
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Jul 20, 2025
qiin2333 added a commit to qiin2333/Sunshine-Foundation that referenced this pull request Jul 20, 2025
* feat: 实现 mic stream 接受处理

* build(cmake): bump c++ to 23 (LizardByte#4096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant