Skip to content

scheduled removal of Trainer.running_sanity_check #9209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2021
Merged

scheduled removal of Trainer.running_sanity_check #9209

merged 3 commits into from
Aug 30, 2021

Conversation

Tshimanga
Copy link
Contributor

@Tshimanga Tshimanga commented Aug 30, 2021 •
edited
Loading

What does this PR do?

Removes deprecated property Trainer.running_sanity_checking as scheduled for 1.5

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Tshimanga
Tshimanga commented Aug 30, 2021
View reviewed changes
@Tshimanga Tshimanga changed the title scheduled removal of deprecated property scheduled removal of Trainer.running_sanity_check Aug 30, 2021
@awaelchli awaelchli added feature Is an improvement or enhancement refactor design Includes a design discussion labels Aug 30, 2021
awaelchli
awaelchli reviewed Aug 30, 2021
View reviewed changes
@awaelchli
Copy link
Contributor

@Tshimanga thanks for helping out here!

@mergify mergify bot added the ready PRs ready to be merged label Aug 30, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 30, 2021
@carmocca carmocca merged commit 34053ef into Lightning-AI:master Aug 30, 2021
@Tshimanga Tshimanga deleted the removal/1.5-running-sanity-check branch August 30, 2021 23:44
@harupy harupy mentioned this pull request Sep 3, 2021
Merged
27 tasks
@radlera
Copy link

radlera commented Nov 26, 2021

Hi there,
it seems this PR had a breaking change with the ray[tune] TuneReportCallback.
Are there plans to fix this already?

@awaelchli
Copy link
Contributor

awaelchli commented Nov 26, 2021 •
edited
Loading

@radlera This was renamed to trainer.sanity_checking.

@awaelchli
Copy link
Contributor

@kaushikb11 makes some updates here as well: ray-project/ray#20562

@dobbali dobbali mentioned this pull request Dec 9, 2021
Closed
2 tasks
ndrwnaguib added a commit to ndrwnaguib/ray that referenced this pull request Jan 24, 2022
@ndrwnaguib
[PTL]: replacing deprecated running_sanity_check with `sanity_check…
a41c93b 
…ing`

`running_sanity_check` was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of `sanity_checking`
@ndrwnaguib ndrwnaguib mentioned this pull request Jan 24, 2022
Merged
6 tasks
amogkam pushed a commit to ray-project/ray that referenced this pull request Jan 25, 2022
@ndrwnaguib
[Tune] PTL replace deprecated running_sanity_check with `sanity_che…
f026376 
…cking` (#21831)

`running_sanity_check` was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of `sanity_checking`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+3 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@Tshimanga @awaelchli @radlera @ananthsub @Borda @carmocca