Skip to content

[Tune] PTL replace deprecated running_sanity_check with sanity_checking #21831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

[Tune] PTL replace deprecated running_sanity_check with sanity_checking #21831

merged 1 commit into from
Jan 25, 2022

Conversation

ndrwnaguib
Copy link
Contributor

@ndrwnaguib ndrwnaguib commented Jan 24, 2022 •
edited
Loading

Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.

I did but getting involved redirects to none? :)

Why are these changes needed?

running_sanity_check was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of sanity_checking

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ndrwnaguib
[PTL]: replacing deprecated running_sanity_check with `sanity_check…
a41c93b 
…ing`

`running_sanity_check` was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of `sanity_checking`
@amogkam amogkam changed the title [PTL]: replacing deprecated running_sanity_check with sanity_checking [Tune] PTL replace deprecated running_sanity_check with sanity_checking Jan 25, 2022
amogkam
amogkam approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@amogkam amogkam merged commit f026376 into ray-project:master Jan 25, 2022
@amogkam amogkam mentioned this pull request Jan 25, 2022
Closed
@ndrwnaguib
Copy link
Contributor Author

You're welcome!

@amogkam amogkam mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndrwnaguib @amogkam