fix: traverse full message tree to find correct user ancestor #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct parent comparison with full message tree traversal. Fixes issue where assistant messages were not found when system messages exist between user and assistant messages.
- Fixes SonarQube duplication warning - Improves code readability
|
adamlui
approved these changes
Jul 28, 2025
adamlui
pushed a commit
that referenced
this pull request
Jul 28, 2025
fix: traverse full message tree to find correct user ancestor ↞ [auto-sync from https://github.com/KudoAI/chatgpt.js]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix chat message ancestor lookup to handle intermediate messages
Summary
This PR fixes a bug where assistant messages were not being found for specific user messages due to direct parent comparison failing when intermediate messages exist.
Bug Description
The original code used direct parent comparison (
data[key].parent == userMessage.id) to find assistant messages that respond to specific user messages. However, this approach fails when there are system messages between the user message and the assistant response, causing assistant messages to not be found at all for those user messages.Fix Details
Replaced the direct parent comparison with a full message tree traversal function
isUserMessageAncestorthat correctly identifies which user message an assistant message responds to, regardless of intermediate messages in the conversation tree.Impact
Files Changed
chatgpt.js- Fixed chat message ancestor lookup to handle intermediate messages