zeromq: disable libunwind to fix pkg-config #36121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
the jenkins build complains that the |
fxcoudert
approved these changes
Jan 18, 2019
MikeMcQuaid
reviewed
Jan 18, 2019
| # https://github.com/Homebrew/homebrew-core/pull/35940#issuecomment-454177261 | ||
| # ENV["LIBUNWIND_LIBS"] = "-framework System" | ||
| # sdk = MacOS::CLT.installed? ? "" : MacOS.sdk_path | ||
| # ENV["LIBUNWIND_CFLAGS"] = "-I#{sdk}/usr/include" |
There was a problem hiding this comment.
I think it's probably worth deleting rather than commenting out the code (that's what the Git history is for) and leaving the link to the PR comment.
There was a problem hiding this comment.
I did so during brew pull --bottle
| @@ -56,5 +59,7 @@ def install | |||
| EOS | |||
| system ENV.cc, "test.c", "-L#{lib}", "-lzmq", "-o", "test" | |||
| system "./test" | |||
| system "pkg-config", "libzmq", "--cflags" | |||
| system "pkg-config", "libzmq", "--libs" | |||
|
thanks for the reviews! |
niheaven
pushed a commit
to niheaven/homebrew-core
that referenced
this pull request
Jan 23, 2019
Closes Homebrew#36121. Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?ZeroMQ uses
libunwindby manually specifying its build flags since macOS provideslibunwindbut without a pkg-config file. That wasn't a problem until the recent zeromq 4.3.1 release changed itslibzmq.pcpkg-config file to requirelibunwind.pc( #35940 (comment) ). I first noticed this in downstream software outside of homebrew-core, but it has also caused a build failure of libbitcoin-protocol in the boost 1.69 pull request ( #35030 ).I submitted a pull request to add
libunwind.pcto brew in Homebrew/brew#5539 but that won't be accepted as long as Homebrew/brew#5068 is outstanding. So as suggested by a zeromq developer ( #35940 (comment) ), this pull request will disablelibunwindsupport until we can resolve thepkg-configissue.I've also added a test for the
pkg-configfile to the formula so we can catch this in the future.