libunwind.pc: add os/mac/pkg-config files #5539
Conversation
This library is provided by macOS and the .pc file is expected by zeromq 4.3.1
| prefix=/usr | ||
| exec_prefix=/usr | ||
| libdir=${exec_prefix}/lib/system | ||
| includedir=${prefix}/include |
There was a problem hiding this comment.
I did notice #5068, but it doesn't affect zeromq in my testing, since libunwind is a private requirement.
Without this pull request, it fails hard because it can't find libunwind.pc:
$ pkg-config --cflags libzmq
Package libunwind was not found in the pkg-config search path.
Perhaps you should add the directory containing `libunwind.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libunwind', required by 'libzmq', not found
With this pull request, it succeeds, but I can't manage to see any reference to libunwind or /usr/include in the pkg-config outputs:
$ pkg-config --cflags libzmq
-I/usr/local/Cellar/zeromq/4.3.1/include
$ pkg-config --libs libzmq
-L/usr/local/Cellar/zeromq/4.3.1/lib -lzmq
$ pkg-config --static libzmq
I was hoping that #5068 wouldn't block this merge because things that depend on zeromq are broken right now. In parallel, I can take a look at helping with #5068.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, in the meantime I've submitted Homebrew/homebrew-core#36121 to disable libunwind from the zeromq formula to unbreak its pkg-config file.
|
This is blocked by #5068 and I'm not actively working on it, so I'm going to close this for now. This can be revisited in the future if so desired. |
brew stylewith your changes locally?brew testswith your changes locally?The libunwind library is provided by macOS but without a pkg-config file. That wasn't a problem until the recent zeromq 4.3.1 release changed its
libzmq.pcpkg-config file to requirelibunwind.pc( Homebrew/homebrew-core#35940 (comment) ). I first noticed this in downstream software outside of homebrew-core, but it has also caused a build failure of libbitcoin-protocol in the boost 1.69 pull request ( Homebrew/homebrew-core#35030 ).I created these
libunwind.pcfiles from the libunwind.pc.in template in the upstream repository and copied the version numbers for 10.12, 10.13, and 10.14 from https://opensource.apple.com/release