boost 1.69.0 #35030

lembacon · 2018-12-12T11:04:54Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

lembacon · 2018-12-12T15:48:18Z

Well, starting Boost 1.69, the tagged layout will include <arch-and-model>. 🙃

https://github.com/boostorg/boost/blob/boost-1.69.0/boostcpp.jam#L156-L157

The library name will look like libboost_regex-mt-x64.dylib, including a -x64 suffix in this case.

lembacon · 2018-12-12T16:13:12Z

Well, starting Boost 1.69, the tagged layout will include <arch-and-model>. 🙃

https://github.com/boostorg/boost/blob/boost-1.69.0/boostcpp.jam#L156-L157

The library name will look like libboost_regex-mt-x64.dylib, including a -x64 suffix in this case.

I think we should keep the layout as-is for now, so I've changed --layout=tagged to --layout=tagged-1.66.

fxcoudert · 2018-12-12T22:02:24Z

Rev-bumping needed for azure-storage-cpp bitcoin btfs cpprestsdk cucumber-cpp folly gnuradio gr-osmosdr graph-tool i2pd ledger lgogdownloader libbitcoin libbitcoin-blockchain libbitcoin-client libbitcoin-database libbitcoin-explorer libbitcoin-network libbitcoin-node libbitcoin-protocol libbitcoin-server libswiften libtorrent-rasterbar metaproxy mkvtoolnix monero ncmpcpp openimageio osquery osrm-backend pcl pdftoedn pgrouting source-highlight uhd upscaledb wesnoth widelands

scpeters · 2018-12-13T21:36:21Z

osquery is missing some boost headers, so it's failing before the no-weak-import issue. I submitted a patch upstream in osquery/osquery#5325, but I don't think it will apply to 3.3.0, and the build is failing anyway.

scpeters · 2018-12-13T23:14:28Z

The boost signals library is removed in 1.69:

https://www.boost.org/users/history/version_1_69_0.html

I maintain one package that uses that; I need to see if we can easily switch to signals2 or if we'll need boost@1.68 in our tap.

scpeters · 2018-12-13T23:36:28Z

Turns out we aren't even using boost signals in the code; it was just searching for the component. I think it will be an easy fix for us; no boost@1.68 needed.

... as in <Homebrew/homebrew-core#35030>.

scpeters · 2019-01-09T20:32:59Z

I tried resolving conflicts through the gui, which created a merge commit and broke CI, so I rebased instead.

…#5325) Summary: boost 1.69 is in a pull request in homebrew-core at Homebrew/homebrew-core#35030 and `osquery` is failing to compile due to using `boost::noncopyable` in a couple header files without including `boost/noncopyable.hpp`: * [jenkins log of build failure](https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/34941/version=high_sierra/testReport/junit/brew-test-bot/high_sierra/install_osquery/) The build still fails on homebrew due to #5284. Pull Request resolved: #5325 Differential Revision: D13464741 Pulled By: fmanco fbshipit-source-id: bdaf573b180f8cdfd08dc719db4829911249caaf

scpeters · 2019-01-10T17:54:48Z

A patch for osquery has been accepted: osquery/osquery@41b785b

A patch for uhd is in the works: EttusResearch/uhd#241 (comment)

scpeters · 2019-01-10T18:00:51Z

The libbitcoin repository was renamed at some point to libbitcoin-system, so the tarball sha256 has changed. Perhaps it should just point to the new repo name with the new sha256.

23:04:59 ==> Downloading from https://codeload.github.com/libbitcoin/libbitcoin-system/tar.gz/v3.5.0
23:04:59 Warning: Formula reports different SHA256: 214d9cd6581330b0e1f6fd8f0c634c46b75ae5515806ecac189f21c0291ae2d9
23:04:59 Downloaded to: /Users/brew/Library/Caches/Homebrew/downloads/d41fab214748b9d248e4047f456139bb9ff328c03f19df07d856ebd51ce75587--libbitcoin-system-3.5.0.tar.gz
23:04:59 SHA256: 44ecd8b0de0dff2296f03e9c7f42a0afb9ac4f916aeaf6de2bffd0ccc05790b5

scpeters · 2019-01-14T22:34:21Z

I've rebased and pushed two fixes:

uhd has an upstream patch for boost 1.69 support
changed url and sha256 for lib bitcoin

scpeters · 2019-01-15T23:55:48Z

that last build took 12 hours; here's a discussion of some (not all) of the failures

libbitcoin-protocol fails to find zeromq during its build, which should be fixed by libunwind.pc: add os/mac/pkg-config files brew#5539
metaproxy had a compilation failure; I've posted a patch to their mailing list as I couldn't find a repository in which to submit pull request
osquery has an upstream patch that can fix its compilation error
pgrouting needs a revision bump (EDIT: weird because it is already revision-bumped)

scpeters · 2019-01-16T00:33:04Z

Ok, oddly, the pgrouting test failure that inspired its revision bump is actually caused by sfcgal. So we should revision bump sfcgal and revert the bump to pgrouting:

https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/36348/version=mojave/testReport/junit/brew-test-bot/mojave/test_pgrouting/

2019-01-15 09:23:53.402 GMT [3726] ERROR:  could not load library "/usr/local/lib/postgresql/postgis-2.5.so": dlopen(/usr/local/lib/postgresql/postgis-2.5.so, 10): Symbol not found: __ZN5boost6system6detail20generic_category_ncxEv
	  Referenced from: /usr/local/opt/sfcgal/lib/libSFCGAL.1.dylib
	  Expected in: /usr/local/opt/boost/lib/libboost_system-mt.dylib
	 in /usr/local/opt/sfcgal/lib/libSFCGAL.1.dylib

scpeters · 2019-01-16T08:31:58Z

I've added a few commits to my fork while we wait for
Homebrew/brew#5539

https://github.com/scpeters/homebrew-core/commits/boost-1.69.0

scpeters · 2019-01-19T00:31:06Z

trying again with more patches...

scpeters · 2019-01-19T16:52:03Z

the build took 11 hours this time; it looks like two of my patches (690046f for graph-tool on 10.13 and 8c74c5a for osquery) didn't work. The other failures are:

folly (pre-existing build failure related to zstd)
libswiften (beware the 280 MB console log that eventually just says scons: building terminated because of errors.)

scpeters · 2019-01-22T18:30:54Z

the osquery patch should apply after osquery 3.3.2 #35941

scpeters · 2019-03-20T08:50:26Z

I'm testing the folly build locally and then I will push if it's ok

fxcoudert · 2019-03-20T09:19:40Z

After that is merged, I would expect graph-tool on 10.13 to be the only failure

Then we should proceed.

scpeters · 2019-03-20T15:18:35Z

I just pushed 🤞

scpeters · 2019-03-21T07:10:18Z

latest build:

expected 10.13 graph-tool failure
https://osquery.io website is down
10.13 failure of brew test cucumber-cpp

seems close enough to me

fxcoudert · 2019-03-21T07:51:34Z

Given that a cpprestsdk was introduced by another merge (sorry), I have merged everything except that. I'll handle it separately in #38115

fxcoudert · 2019-03-21T07:51:46Z

Congrats @scpeters @lembacon on great work!

henryiii · 2019-04-12T13:03:18Z

How hard will Boost 1.70 be to add? Really looking forward to Boost:::Histogram!

lembacon force-pushed the boost-1.69.0 branch from e5ee5b6 to 151597a Compare December 12, 2018 16:11

lembacon force-pushed the boost-1.69.0 branch 2 times, most recently from a38ba87 to 54eea6f Compare December 13, 2018 07:00

scpeters mentioned this pull request Dec 13, 2018

Fix build with boost 1.69: add missing boost/noncopyable.hpp includes osquery/osquery#5325

Closed

lembacon force-pushed the boost-1.69.0 branch from 54eea6f to dc7e846 Compare December 26, 2018 13:01

tabe added a commit to flintproject/Flint that referenced this pull request Jan 8, 2019

Avoid arch-and-model suffix introduced at Boost 1.69

d04db3e

... as in <Homebrew/homebrew-core#35030>.

scpeters force-pushed the boost-1.69.0 branch from 8527f88 to 14f79e2 Compare January 9, 2019 20:30

scpeters mentioned this pull request Jan 10, 2019

expert_nodes.hpp: include boost noncopyable.hpp EttusResearch/uhd#241

Closed

4 tasks

scpeters force-pushed the boost-1.69.0 branch from 14f79e2 to 839c931 Compare January 14, 2019 22:31

scpeters mentioned this pull request Jan 15, 2019

libunwind.pc: add os/mac/pkg-config files Homebrew/brew#5539

Closed

6 tasks

scpeters mentioned this pull request Jan 17, 2019

zeromq: disable libunwind to fix pkg-config #36121

Closed

5 tasks

scpeters force-pushed the boost-1.69.0 branch from 36bdd32 to 8f4bc2e Compare January 19, 2019 00:29

tschoonj mentioned this pull request Jan 22, 2019

librsvg 2.44.12 #36244

Closed

scpeters and others added 15 commits March 20, 2019 01:37

osquery: revision for boost

293e1cc

osrm-backend: revision for boost

83e0663

pcl: revision for boost

197229d

pdftoedn: revision for boost

889685d

pgrouting: revision for boost

b188679

sfcgal: revision for boost

99b7236

source-highlight: revision for boost

b744190

uhd: revision for boost

47d7363

upscaledb: revision for boost

11b4f33

wesnoth: revision for boost

0013572

widelands: revision for boost

2daea44

libswiften: patch for boost 1.69

93e9f6e

metaproxy: patch for boost 1.69

3ffc1f1

osquery: patch for boost 1.69

3053520

uhd: patch for boost 1.69

d894381

scpeters force-pushed the boost-1.69.0 branch from 5cfbd54 to d894381 Compare March 20, 2019 15:10

scpeters removed the revision bumps needed Reverse dependencies need to have their revision incremented in the same PR label Mar 21, 2019

fxcoudert closed this in b5b2096 Mar 21, 2019

fxcoudert mentioned this pull request Mar 21, 2019

cpprestsdk: revision for boost #38115

Closed

lembacon deleted the boost-1.69.0 branch March 21, 2019 08:10

scpeters mentioned this pull request Apr 19, 2019

boost: avoid zstd opportunistic linkage #39117

Closed

5 tasks

lock bot added the outdated PR was locked due to age label May 12, 2019

lock bot locked as resolved and limited conversation to collaborators May 12, 2019

Uh oh!

boost 1.69.0 #35030

boost 1.69.0 #35030

Uh oh!

Conversation

lembacon commented Dec 12, 2018

Uh oh!

lembacon commented Dec 12, 2018

Uh oh!

lembacon commented Dec 12, 2018

Uh oh!

fxcoudert commented Dec 12, 2018

Uh oh!

scpeters commented Dec 13, 2018

Uh oh!

scpeters commented Dec 13, 2018

Uh oh!

scpeters commented Dec 13, 2018

Uh oh!

scpeters commented Jan 9, 2019

Uh oh!

scpeters commented Jan 10, 2019

Uh oh!

scpeters commented Jan 10, 2019

Uh oh!

scpeters commented Jan 14, 2019

Uh oh!

scpeters commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scpeters commented Jan 16, 2019

Uh oh!

scpeters commented Jan 16, 2019

Uh oh!

scpeters commented Jan 19, 2019

Uh oh!

scpeters commented Jan 19, 2019

Uh oh!

scpeters commented Jan 22, 2019

Uh oh!

scpeters commented Mar 20, 2019

Uh oh!

fxcoudert commented Mar 20, 2019

Uh oh!

scpeters commented Mar 20, 2019

Uh oh!

scpeters commented Mar 21, 2019

Uh oh!

fxcoudert commented Mar 21, 2019

Uh oh!

fxcoudert commented Mar 21, 2019

Uh oh!

henryiii commented Apr 12, 2019

Uh oh!

Uh oh!

scpeters commented Jan 15, 2019 •

edited

Loading