Skip to content

go 1.25.0, go@1.24 1.24.6 (new formula) #226636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 13, 2025
Merged

go 1.25.0, go@1.24 1.24.6 (new formula) #226636

merged 12 commits into from
Aug 13, 2025

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jun 12, 2025 •
edited
Loading

Announcements:

Release notes:

Go 1.25 milestone: GitHub milestone details (release blockers, commits, PRs)

Go release dashboard: https://dev.golang.org/release

Downloads: https://go.dev/dl/

Related/similar previous:

Builds:

Problematic dependants formulae:

Due to Go 1.25 changes

Needs specific support for Go 1.25 upstream

Formula revision bump needed (in this PR)

  • errcheck: test failure: package requires newer Go version go1.25 (application built with go1.24) -: This application uses version go1.24 of the source-processing packages but runs version go1.25 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.]
  • golangci-lint: test failure: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25)
  • govulncheck: test failure: Loading packages failed, possibly due to a mismatch between the Go version used to build govulncheck and the Go version on PATH. Consider rebuilding govulncheck with the current Go version.
  • llgo: test failure: ==> /opt/homebrew/Cellar/llgo/0.11.5/bin/llgo run . -: # os /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/exec.go:58:18: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/exec.go:137:22: undefined: runtime.AddCleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/file_unix.go:66:22: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/file_unix.go:226:22: undefined: runtime.AddCleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/root_openat.go:29:18: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/root_unix.go:59:27: undefined: runtime.AddCleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/exec.go:58:18: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/file_unix.go:66:22: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/root_openat.go:29:18: undefined: runtime.Cleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/exec.go:137:22: undefined: runtime.AddCleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/file_unix.go:226:22: undefined: runtime.AddCleanup /opt/homebrew/Cellar/go/1.25rc2/libexec/src/os/root_unix.go:59:27: undefined: runtime.AddCleanup -: This application uses version go1.24 of the source-processing packages but runs version go1.25 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go. cannot build SSA for package os cannot build SSA for package fmt /private/tmp/llgo-test-20250709-52224-xuw5y6/hello.go:1:1: package requires newer Go version go1.25 (application built with go1.24) -: This application uses version go1.24 of the source-processing packages but runs version go1.25 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go. cannot build SSA for package hello panic: cannot build SSA for packages
    Test failed even with revision bump.
    llgo brew release with go1.25 fail goplus/llgo#1221
    llgo:lock Go dependency to go@1.24 #234050
  • staticcheck: test failure: module requires at least go1.25rc1, but Staticcheck was built with go1.24.4

Needs golang.org/x/tools bump to >= v0.34.0

Needs github.com/bytedance/sonic bump to >= v1.14.0

Needs github.com/cockroachdb/swiss upgrade after cockroachdb/swiss@d6e517c

Hash mismatches (label "checksum mismatch")

Transient

  • eget: test failure: Github API rate limit exceeded
  • openbao: build failure: YN0000: Failed with errors in 26m 5s
  • parca: build failure: ERR_PNPM_FETCH_504  GET https://registry.npmjs.org/@storybook%2Faddon-docs: Gateway Timeout - 504
  • phoneinfoga: build failure: The remote server failed to provide the requested resource ➤ YN0035: │ Response Code: 503 (Service Unavailable)
  • prometheus: build failure: fatal: not a git repository (or any of the parent directories): .git, npm error 503 Service Unavailable
  • sqlboiler: build failure: go: downloading modernc.org/sqlite v1.18.1 drivers/sqlboiler-sqlite3/driver/sqlite3.go:12:2: modernc.org/sqlite@v1.18.1: Get "https://proxy.golang.org/modernc.org/sqlite/@v/v1.18.1.zip": dial tcp 74.125.193.141:443: connect: operation timed out

Other / Unknown / not yet categorized

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@stefanb stefanb added in progress Stale bot should stay away prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing labels Jun 12, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. autobump alias labels Jun 12, 2025
@stefanb stefanb force-pushed the go-1.25 branch 2 times, most recently from d913486 to d862731 Compare June 12, 2025 04:25
@stefanb stefanb marked this pull request as draft June 12, 2025 04:29
@chenrui333
Copy link
Member

looks like linux arm dependency builds did not get triggered.

@stefanb stefanb mentioned this pull request Jun 14, 2025
Merged
kezhenxu94 pushed a commit to apache/skywalking-eyes that referenced this pull request Jun 14, 2025
@stefanb
Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility (#201)
a62f574 
The build error with Go 1.25 manifests as:
go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/tools@v0.21.1-0.20240508182429-e35e4ccd0d2d/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

updated via
go get -u golang.org/x/tools
go mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream x/tools fix: https://go-review.googlesource.com/c/tools/+/675955
* Problem found in Homebrew/homebrew-core#226636
This was referenced Jun 14, 2025
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 15, 2025
Closed
Merged
mhilton pushed a commit to influxdata/flux that referenced this pull request Jun 16, 2025
@stefanb
build(deps): Bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibi…
0c5580e 
…lity (#5543)

Build with Go 1.25 fails with:
  go generate -tags '' ./libflux/go/libflux
  env GO111MODULE=on go build -tags '' ./...
  go: downloading github.com/dave/jennifer v1.2.0
  go: downloading golang.org/x/mod v0.18.0
  # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/tools@v0.22.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
  make: *** [build] Error 1

Bumped via:
go1.25rc1 get -u golang.org/x/tools
go: upgraded golang.org/x/crypto v0.36.0 => v0.39.0
go: upgraded golang.org/x/mod v0.24.0 => v0.25.0
go: upgraded golang.org/x/net v0.38.0 => v0.41.0
go: upgraded golang.org/x/sync v0.12.0 => v0.15.0
go: upgraded golang.org/x/sys v0.31.0 => v0.33.0
go: upgraded golang.org/x/term v0.30.0 => v0.32.0
go: upgraded golang.org/x/text v0.23.0 => v0.26.0
go: upgraded golang.org/x/tools v0.30.0 => v0.34.0

go1.25rc1 mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b
* Problem found in Homebrew/homebrew-core#226636
stefanb added a commit to stefanb/legitify that referenced this pull request Jun 19, 2025
@stefanb
Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility
93d1b57 
The build error with Go 1.25 manifests as:

go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/tools@v0.13.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)

go1.25rc1 get -u golang.org/x/tools
go: upgraded go 1.19 => 1.23.0
go: upgraded golang.org/x/crypto v0.21.0 => v0.39.0
go: upgraded golang.org/x/mod v0.12.0 => v0.25.0
go: upgraded golang.org/x/net v0.23.0 => v0.41.0
go: upgraded golang.org/x/sync v0.3.0 => v0.15.0
go: upgraded golang.org/x/sys v0.20.0 => v0.33.0
go: upgraded golang.org/x/term v0.18.0 => v0.32.0
go: upgraded golang.org/x/text v0.14.0 => v0.26.0
go: upgraded golang.org/x/tools v0.13.0 => v0.34.0

go1.25rc1 mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b
* Problem found in Homebrew/homebrew-core#226636
This was referenced Jun 19, 2025
Open
Draft
hailaz added a commit to gogf/gf that referenced this pull request Jun 20, 2025
@hailaz
chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility (#…
09ec907 
…4313)

chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility

```
   # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/tools@v0.21.1-0.20240508182429-e35e4ccd0d2d/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
```

relates to Homebrew/homebrew-core#226636
@stefanb stefanb mentioned this pull request Jun 24, 2025
Merged
@bevanjkay bevanjkay mentioned this pull request Aug 13, 2025
Closed
6 tasks
This was referenced Aug 13, 2025
Merged
Merged
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@stefanb stefanb mentioned this pull request Aug 13, 2025
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @stefanb has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 13, 2025
@BrewTestBot BrewTestBot enabled auto-merge August 13, 2025 19:40
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit 6459e6e Aug 13, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the go-1.25 branch August 13, 2025 19:54
This was referenced Aug 13, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 14, 2025
Merged
6 tasks
@calvinit calvinit mentioned this pull request Aug 15, 2025
Merged
6 tasks
@stefanb stefanb mentioned this pull request Aug 22, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
alias automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanb @chenrui333 @carlocab @BrewTestBot