[core] Fixed bug in srt_epoll_uwait: wrong number of sockets returned #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
pushed a commit
to ethouris/srt
that referenced
this pull request
Aug 20, 2025
cl-ment
approved these changes
Aug 21, 2025
cl-ment
pushed a commit
that referenced
this pull request
Aug 26, 2025
…shared mutex (#3189) * [MAINT] Added optional test discovery. Added improvements for attributes * Enabled C++17 version of shared mutex when compiling in C++17 mode * [core] Rework m_bListening to lock-free and m_GlobControlLock to use shared mutex * Added UT discovery option to configure * Changed enabled std::shared_mutex only if compiling with stdc++-sync * Fixed problem with not updated sync.cpp SharedMutex * Removed dead code * Fixed review findings * Demoted some locks on m_GlobControlLock to shared. Added false positive TSan info * Merged changes from #3200 * Added a fix that should repair the problem reported in 3196. Still needs rechecks * Fixed incorrect shared lock applied for a case when a new group is to be created (required exclusive) --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop that was rolling over the events in the container was incorrectly increasing the total counter over the number of actually filled items in the array. The loop was refactored to return the exact number of array items filled.