Skip to content

Conversation

maxsharabayko
Copy link
Collaborator

Extracted changes from #2527 that don't touch the logic and thus can be safely merged. Having them merged would reduce the reviewing scope of PR #2527. Also there might be follow up changes to the TSBPD logic partially correlated with #2527, so I would like to avoid merge conflicts as much as possible.

  • Minor internal logging format changes.
  • Renamed CUDT::m_bTsbPdAckWakeup to m_bTsbPdNeedsWakeup. There is no need to wait for an ACK to be sent as it does no longer change the read-ready state.
  • Added some function to the CRcvBuffer.

Also renamed CUDT::m_bTsbPdAckWakeup.
Added some function to the CRcvBuffer.
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Apr 24, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 24, 2024
@maxsharabayko maxsharabayko requested a review from ethouris April 24, 2024 12:37
@maxsharabayko maxsharabayko merged commit 882dff9 into Haivision:master Apr 24, 2024
@maxsharabayko maxsharabayko deleted the develop/minor-changes-from-2527 branch April 24, 2024 14:18
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
Also renamed CUDT::m_bTsbPdAckWakeup.
Added some function to the CRcvBuffer.

Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
Also renamed CUDT::m_bTsbPdAckWakeup.
Added some function to the CRcvBuffer.

Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko added a commit that referenced this pull request Apr 29, 2024
Also renamed CUDT::m_bTsbPdAckWakeup.
Added some function to the CRcvBuffer.

Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant