Skip to content

Conversation

maxsharabayko
Copy link
Collaborator

Count the number of packets dropped by a group based on the offset of the base RCV seqno towards seqno of a packet being read.

Fixes #2933.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Apr 19, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 19, 2024
@maxsharabayko maxsharabayko requested a review from ethouris April 19, 2024 13:00
@maxsharabayko
Copy link
Collaborator Author

Proceeding with this fix to unblock some other activities, but logging the remaining thing to fix in #2936.

@maxsharabayko maxsharabayko merged commit f6c2315 into Haivision:master Apr 22, 2024
@maxsharabayko maxsharabayko deleted the hotfix/rfc-drop-cnt branch April 22, 2024 08:09
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 24, 2024
maxsharabayko added a commit that referenced this pull request Apr 25, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Apr 26, 2024
maxsharabayko added a commit that referenced this pull request Apr 29, 2024
Also fixed m_iAvgPayloadSize initialization.
maxsharabayko added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Group receiver does not count dropped packets.
2 participants