Skip to content

Caching logger enable state to avoid lenghty checks with every log call #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2024
Merged

Caching logger enable state to avoid lenghty checks with every log call #2858

merged 2 commits into from
Jan 18, 2024

Conversation

ethouris
Copy link
Collaborator

Changes:

  1. Part of the logging implementation so far in common.cpp has been extracted to its own imp file, logging.cpp. The SendLogLine function is also moved there.
  2. The CheckEnabled() now resolves to reading a cache variable, which is updated through functions that change the logging configuration. This shortens the call that is being done with every logging call.

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Jan 18, 2024
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Jan 18, 2024
@maxsharabayko maxsharabayko merged commit d9069a5 into Haivision:master Jan 18, 2024
ethouris pushed a commit to ethouris/srt that referenced this pull request Mar 5, 2024
Withdrawn changes from Haivision#2858 as they break ABI compat
6ebf94f
@ethouris ethouris mentioned this pull request Mar 5, 2024
Merged
maxsharabayko pushed a commit that referenced this pull request Mar 6, 2024
@ethouris
[core] Withdrawn changes from #2858 as they break ABI compat (#2899).
710c202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ethouris @maxsharabayko